minor #60233 [String] ignore the current locale before transliterating ASCII codes with iconv() (xabbuh)

nicolas-grekas · nicolas-grekas · commit 330e167e29b1 · 2025-04-18T17:16:02.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [String] ignore the current locale before transliterating ASCII codes with iconv() | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT see https://github.com/symfony/symfony/actions/runs/14509713498/job/40705561464?pr=58370#step:9:1891 Commits ------- d304d5d ignore the current locale before transliterating ASCII codes with iconv()
diff --git a/src/Symfony/Component/String/AbstractUnicodeString.php b/src/Symfony/Component/String/AbstractUnicodeString.php
@@ -135,15 +135,21 @@ public function ascii(array $rules = []): self
             } elseif (!\function_exists('iconv')) {
                 $s = preg_replace('/[^\x00-\x7F]/u', '?', $s);
             } else {
-                $s = @preg_replace_callback('/[^\x00-\x7F]/u', static function ($c) {
-                    $c = (string) iconv('UTF-8', 'ASCII//TRANSLIT', $c[0]);
-
-                    if ('' === $c && '' === iconv('UTF-8', 'ASCII//TRANSLIT', '²')) {
-                        throw new \LogicException(sprintf('"%s" requires a translit-able iconv implementation, try installing "gnu-libiconv" if you\'re using Alpine Linux.', static::class));
-                    }
+                $previousLocale = setlocale(\LC_CTYPE, 0);
+                try {
+                    setlocale(\LC_CTYPE, 'C');
+                    $s = @preg_replace_callback('/[^\x00-\x7F]/u', static function ($c) {
+                        $c = (string) iconv('UTF-8', 'ASCII//TRANSLIT', $c[0]);
+
+                        if ('' === $c && '' === iconv('UTF-8', 'ASCII//TRANSLIT', '²')) {
+                            throw new \LogicException(sprintf('"%s" requires a translit-able iconv implementation, try installing "gnu-libiconv" if you\'re using Alpine Linux.', static::class));
+                        }
 
-                    return 1 < \strlen($c) ? ltrim($c, '\'`"^~') : ('' !== $c ? $c : '?');
-                }, $s);
+                        return 1 < \strlen($c) ? ltrim($c, '\'`"^~') : ('' !== $c ? $c : '?');
+                    }, $s);
+                } finally {
+                    setlocale(\LC_CTYPE, $previousLocale);
+                }
             }
         }
 
diff --git a/src/Symfony/Component/String/Tests/Slugger/AsciiSluggerTest.php b/src/Symfony/Component/String/Tests/Slugger/AsciiSluggerTest.php
@@ -106,4 +106,19 @@ public static function provideSlugEmojiTests(): iterable
             'undefined_locale', // Behaves the same as if emoji support is disabled
         ];
     }
+
+    /**
+     * @requires extension intl
+     */
+    public function testSlugEmojiWithSetLocale()
+    {
+        if (!setlocale(LC_ALL, 'C.UTF-8')) {
+            $this->markTestSkipped('Unable to switch to the "C.UTF-8" locale.');
+        }
+
+        $slugger = new AsciiSlugger();
+        $slugger = $slugger->withEmoji(true);
+
+        $this->assertSame('a-and-a-go-to', (string) $slugger->slug('a 😺, 🐈‍⬛, and a 🦁 go to 🏞️... 😍 🎉 💛', '-'));
+    }
 }
