Deprecate container params router.request_context.*

stollr · stollr · commit 3493bccffd60 · 2025-08-20T10:04:48.000+02:00
The `framework.router.default_uri` config is used to define the request context as fallback for the case that no HTTP request is available. But it does not affect the container params - `router.request_context.base_url` - `router.request_context.host` - `router.request_context.scheme` They still use the defaults, which are defined in the routing.php config file. This leads to inconsistency and confusion if a third party bundle relies on the container parameters instead of the request context service. This PR deprecates those container params like proposed in #53919.
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -33,6 +33,8 @@ FrameworkBundle
 ---------------
 
  * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `addCommand()`
+ * Deprecate the container params `router.request_context.scheme`, `router.request_context.host`
+   and `router.request_context.base_url`, use the `framework.router.default_uri` config instead.
 
 HtmlSanitizer
 -------------
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -8,6 +8,8 @@ CHANGELOG
  * Allow using their name without added suffix when using `#[Target]` for custom services
  * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `Symfony\Bundle\FrameworkBundle\Console\Application::addCommand()`
  * Add `assertEmailAddressNotContains()` to the `MailerAssertionsTrait`
+ * Deprecate the container params `router.request_context.scheme`, `router.request_context.host`
+   and `router.request_context.base_url`, use the `framework.router.default_uri` config instead.
 
 7.3
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1307,6 +1307,9 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co
 
         $loader->load('routing.php');
 
+        $container->deprecateParameter('router.request_context.scheme', 'symfony/framework-bundle', '7.4', '"router.request_context.scheme" is deprecated, use the "framework.router.default_uri" config instead.');
+        $container->deprecateParameter('router.request_context.host', 'symfony/framework-bundle', '7.4', '"router.request_context.host" is deprecated, use the "framework.router.default_uri" config instead.');
+
         if ($config['utf8']) {
             $container->getDefinition('routing.loader')->replaceArgument(1, ['utf8' => true]);
         }
@@ -1334,8 +1337,7 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co
         $container->setParameter('request_listener.https_port', $config['https_port']);
 
         if (null !== $config['default_uri']) {
-            $container->getDefinition('router.request_context')
-                ->replaceArgument(0, $config['default_uri']);
+            $container->setParameter('router.request_context.base_url', $config['default_uri']);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1307,6 +1307,9 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co`
`1307`	`1307`
`1308`	`1308`	`$loader->load('routing.php');`
`1309`	`1309`
	`1310`	`+ $container->deprecateParameter('router.request_context.scheme', 'symfony/framework-bundle', '7.4', '"router.request_context.scheme" is deprecated, use the "framework.router.default_uri" config instead.');`
	`1311`	`+ $container->deprecateParameter('router.request_context.host', 'symfony/framework-bundle', '7.4', '"router.request_context.host" is deprecated, use the "framework.router.default_uri" config instead.');`
	`1312`	`+`
`1310`	`1313`	`if ($config['utf8']) {`
`1311`	`1314`	`$container->getDefinition('routing.loader')->replaceArgument(1, ['utf8' => true]);`
`1312`	`1315`	`}`
`@@ -1334,8 +1337,7 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co`
`1334`	`1337`	`$container->setParameter('request_listener.https_port', $config['https_port']);`
`1335`	`1338`
`1336`	`1339`	`if (null !== $config['default_uri']) {`
`1337`		`- $container->getDefinition('router.request_context')`
`1338`		`- ->replaceArgument(0, $config['default_uri']);`
	`1340`	`+ $container->setParameter('router.request_context.base_url', $config['default_uri']);`
`1339`	`1341`	`}`
`1340`	`1342`	`}`
`1341`	`1343`