[Security] Make impersonation_path() argument mandatory

alexandre-daubois · alexandre-daubois · commit 3ed6fbdf2007 · 2023-10-02T10:52:41.000+02:00
diff --git a/src/Symfony/Bridge/Twig/CHANGELOG.md b/src/Symfony/Bridge/Twig/CHANGELOG.md
@@ -7,6 +7,7 @@ CHANGELOG
  * Allow an array to be passed as the first argument to the `importmap()` Twig function
  * Add `TemplatedEmail::locale()` to set the locale for the email rendering
  * Add `AppVariable::getEnabledLocales()` to retrieve the enabled locales
+ * Add `impersonate_path()` Twig function
 
 6.3
 ---
diff --git a/src/Symfony/Bridge/Twig/Extension/SecurityExtension.php b/src/Symfony/Bridge/Twig/Extension/SecurityExtension.php
@@ -69,7 +69,7 @@ public function getImpersonateExitPath(string $exitTo = null): string
         return $this->impersonateUrlGenerator->generateExitPath($exitTo);
     }
 
-    public function getImpersonatePath(string $identifier = null): string
+    public function getImpersonatePath(string $identifier): string
     {
         if (null === $this->impersonateUrlGenerator) {
             return '';
diff --git a/src/Symfony/Component/Security/Http/Impersonate/ImpersonateUrlGenerator.php b/src/Symfony/Component/Security/Http/Impersonate/ImpersonateUrlGenerator.php
@@ -36,7 +36,7 @@ public function __construct(RequestStack $requestStack, FirewallMap $firewallMap
         $this->firewallMap = $firewallMap;
     }
 
-    public function generateImpersonationPath(string $identifier = null): string
+    public function generateImpersonationPath(string $identifier): string
     {
         return $this->buildPath(null, $identifier);
     }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function getImpersonateExitPath(string $exitTo = null): string`
`69`	`69`	`return $this->impersonateUrlGenerator->generateExitPath($exitTo);`
`70`	`70`	`}`
`71`	`71`
`72`		`- public function getImpersonatePath(string $identifier = null): string`
	`72`	`+ public function getImpersonatePath(string $identifier): string`
`73`	`73`	`{`
`74`	`74`	`if (null === $this->impersonateUrlGenerator) {`
`75`	`75`	`return '';`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function __construct(RequestStack $requestStack, FirewallMap $firewallMap`
`36`	`36`	`$this->firewallMap = $firewallMap;`
`37`	`37`	`}`
`38`	`38`
`39`		`- public function generateImpersonationPath(string $identifier = null): string`
	`39`	`+ public function generateImpersonationPath(string $identifier): string`
`40`	`40`	`{`
`41`	`41`	`return $this->buildPath(null, $identifier);`
`42`	`42`	`}`