minor #60148 Remove non-final readonly classes (nicolas-grekas)

fabpot · fabpot · commit 46bd34c79cc7 · 2025-04-06T18:16:13.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- Remove non-final readonly classes | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Those are just annoying from a maintainer PoV, without providing us any extra maintenance flexibility (quite the contrary). Commits ------- bbba700 Remove non-final readonly classes
diff --git a/src/Symfony/Component/ObjectMapper/Attribute/Map.php b/src/Symfony/Component/ObjectMapper/Attribute/Map.php
@@ -19,7 +19,7 @@
  * @author Antoine Bluchet <soyuka@gmail.com>
  */
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_PROPERTY | \Attribute::IS_REPEATABLE)]
-readonly class Map
+class Map
 {
     /**
      * @param string|class-string|null                                                                              $source    The property or the class to map from
@@ -28,10 +28,10 @@
      * @param (string|callable(mixed, object): mixed)|(string|callable(mixed, object): mixed)[]|null $transform A service id or a callable that transforms the value during mapping
      */
     public function __construct(
-        public ?string $target = null,
-        public ?string $source = null,
-        public mixed $if = null,
-        public mixed $transform = null,
+        public readonly ?string $target = null,
+        public readonly ?string $source = null,
+        public readonly mixed $if = null,
+        public readonly mixed $transform = null,
     ) {
     }
 }
diff --git a/src/Symfony/Component/ObjectMapper/Metadata/Mapping.php b/src/Symfony/Component/ObjectMapper/Metadata/Mapping.php
@@ -11,26 +11,15 @@
 
 namespace Symfony\Component\ObjectMapper\Metadata;
 
+use Symfony\Component\ObjectMapper\Attribute\Map;
+
 /**
  * Configures a class or a property to map to.
  *
  * @internal
  *
  * @author Antoine Bluchet <soyuka@gmail.com>
  */
-readonly class Mapping
+final class Mapping extends Map
 {
-    /**
-     * @param string|class-string|null                                                               $source    The property or the class to map from
-     * @param string|class-string|null                                                               $target    The property or the class to map to
-     * @param string|bool|callable(mixed, object): bool|null                                         $if        A boolean, Symfony service name or a callable that instructs whether to map
-     * @param (string|callable(mixed, object): mixed)|(string|callable(mixed, object): mixed)[]|null $transform A service id or a callable that transform the value during mapping
-     */
-    public function __construct(
-        public ?string $target = null,
-        public ?string $source = null,
-        public mixed $if = null,
-        public mixed $transform = null,
-    ) {
-    }
 }
diff --git a/src/Symfony/Component/ObjectMapper/Tests/Fixtures/MapStruct/Map.php b/src/Symfony/Component/ObjectMapper/Tests/Fixtures/MapStruct/Map.php
@@ -14,6 +14,6 @@
 use Symfony\Component\ObjectMapper\Attribute\Map as AttributeMap;
 
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_PROPERTY | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]
-readonly class Map extends AttributeMap
+class Map extends AttributeMap
 {
 }
diff --git a/src/Symfony/Component/Security/Http/Attribute/IsGrantedContext.php b/src/Symfony/Component/Security/Http/Attribute/IsGrantedContext.php
@@ -17,12 +17,12 @@
 use Symfony\Component\Security\Core\Authorization\Voter\AuthenticatedVoter;
 use Symfony\Component\Security\Core\User\UserInterface;
 
-readonly class IsGrantedContext implements AuthorizationCheckerInterface
+class IsGrantedContext implements AuthorizationCheckerInterface
 {
     public function __construct(
-        public TokenInterface $token,
-        public ?UserInterface $user,
-        private AuthorizationCheckerInterface $authorizationChecker,
+        public readonly TokenInterface $token,
+        public readonly ?UserInterface $user,
+        private readonly AuthorizationCheckerInterface $authorizationChecker,
     ) {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@`
`14`	`14`	`use Symfony\Component\ObjectMapper\Attribute\Map as AttributeMap;`
`15`	`15`
`16`	`16`	`#[\Attribute(\Attribute::TARGET_CLASS \| \Attribute::TARGET_PROPERTY \| \Attribute::TARGET_METHOD \| \Attribute::IS_REPEATABLE)]`
`17`		`-readonly class Map extends AttributeMap`
	`17`	`+class Map extends AttributeMap`
`18`	`18`	`{`
`19`	`19`	`}`