Remove non-final readonly classes #60148
Merged
+13
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Apr 4, 2025
f618ad7 to
47e92c3
Compare
alexandre-daubois
approved these changes
Apr 4, 2025
chalasr
approved these changes
Apr 4, 2025
47e92c3 to
bbba700
Compare
derrabus
reviewed
Apr 4, 2025
| /** | ||
| * Configures a class or a property to map to. | ||
| * | ||
| * @internal | ||
| * | ||
| * @author Antoine Bluchet <soyuka@gmail.com> | ||
| */ | ||
| readonly class Mapping | ||
| final class Mapping extends Map |
There was a problem hiding this comment.
Do we really want to introduce this type inheritance?
There was a problem hiding this comment.
the class is internal so we can undo it at will. For now, it prevents duplicate definitions/docblocks IMHO
yceruto
approved these changes
Apr 4, 2025
mtarld
approved these changes
Apr 4, 2025
soyuka
approved these changes
Apr 4, 2025
fabpot
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are just annoying from a maintainer PoV, without providing us any extra maintenance flexibility (quite the contrary).