[DomCrawler] Catch expected ValueError.

derrabus · derrabus · commit 4eb13beb8586 · 2020-05-22T18:49:08.000+02:00
diff --git a/composer.json b/composer.json
@@ -31,7 +31,8 @@
         "symfony/polyfill-intl-icu": "~1.0",
         "symfony/polyfill-mbstring": "~1.0",
         "symfony/polyfill-php56": "~1.0",
-        "symfony/polyfill-php70": "~1.6"
+        "symfony/polyfill-php70": "~1.6",
+        "symfony/polyfill-php80": "~1.17"
     },
     "replace": {
         "symfony/asset": "self.version",
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -193,10 +193,11 @@ public function addHtmlContent($content, $charset = 'UTF-8')
             // Convert charset to HTML-entities to work around bugs in DOMDocument::loadHTML()
             $content = mb_convert_encoding($content, 'HTML-ENTITIES', $charset);
         } catch (\Exception $e) {
+        } catch (\ValueError $e) {
+        } finally {
+            restore_error_handler();
         }
 
-        restore_error_handler();
-
         if ('' !== trim($content)) {
             @$dom->loadHTML($content);
         }
diff --git a/src/Symfony/Component/DomCrawler/composer.json b/src/Symfony/Component/DomCrawler/composer.json
@@ -18,7 +18,8 @@
     "require": {
         "php": "^5.5.9|>=7.0.8",
         "symfony/polyfill-ctype": "~1.8",
-        "symfony/polyfill-mbstring": "~1.0"
+        "symfony/polyfill-mbstring": "~1.0",
+        "symfony/polyfill-php80": "~1.17"
     },
     "require-dev": {
         "symfony/css-selector": "~2.8|~3.0|~4.0"

Original file line number	Diff line number	Diff line change
`@@ -193,10 +193,11 @@ public function addHtmlContent($content, $charset = 'UTF-8')`
`193`	`193`	`// Convert charset to HTML-entities to work around bugs in DOMDocument::loadHTML()`
`194`	`194`	`$content = mb_convert_encoding($content, 'HTML-ENTITIES', $charset);`
`195`	`195`	`} catch (\Exception $e) {`
	`196`	`+ } catch (\ValueError $e) {`
	`197`	`+ } finally {`
	`198`	`+ restore_error_handler();`
`196`	`199`	`}`
`197`	`200`
`198`		`- restore_error_handler();`
`199`		`-`
`200`	`201`	`if ('' !== trim($content)) {`
`201`	`202`	`@$dom->loadHTML($content);`
`202`	`203`	`}`