minor #57792 Replace TestCase::assertTrue(true) with TestCase::expectNotToPerformAssertions() (alexandre-daubois)

xabbuh · xabbuh · commit 78de59be7e54 · 2024-07-22T09:48:24.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- Replace `TestCase::assertTrue(true)` with `TestCase::expectNotToPerformAssertions()` | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- ee8509e Replace `TestCase::assertTrue(true)` with `TestCase::expectNotToPerformAssertions()`
diff --git a/src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php b/src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php
@@ -53,6 +53,8 @@ public function testUnsupportedShellOption()
 
     public function testAdditionalShellSupport()
     {
+        $this->expectNotToPerformAssertions();
+
         $this->command = new CompleteCommand(['supported' => BashCompletionOutput::class]);
         $this->command->setApplication($this->application);
         $this->tester = new CommandTester($this->command);
@@ -61,8 +63,6 @@ public function testAdditionalShellSupport()
 
         // verify that the default set of shells is still supported
         $this->execute(['--shell' => 'bash', '--current' => '1', '--input' => ['bin/console']]);
-
-        $this->assertTrue(true);
     }
 
     /**
diff --git a/src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php b/src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
@@ -27,11 +27,10 @@ protected function setUp(): void
      */
     public function testRewindOnFtp()
     {
-        $i = new RecursiveDirectoryIterator('ftp://speedtest:speedtest@ftp.otenet.gr/', \RecursiveDirectoryIterator::SKIP_DOTS);
+        $this->expectNotToPerformAssertions();
 
+        $i = new RecursiveDirectoryIterator('ftp://speedtest:speedtest@ftp.otenet.gr/', \RecursiveDirectoryIterator::SKIP_DOTS);
         $i->rewind();
-
-        $this->assertTrue(true);
     }
 
     /**
diff --git a/src/Symfony/Component/Mailer/Tests/MailerTest.php b/src/Symfony/Component/Mailer/Tests/MailerTest.php
@@ -86,6 +86,8 @@ public function dispatch($message, array $stamps = []): Envelope
 
     public function testRejectMessage()
     {
+        $this->expectNotToPerformAssertions();
+
         $dispatcher = new EventDispatcher();
         $dispatcher->addListener(MessageEvent::class, fn (MessageEvent $event) => $event->reject(), 255);
         $dispatcher->addListener(MessageEvent::class, fn () => throw new \RuntimeException('Should never be called.'));
@@ -111,6 +113,5 @@ public function __toString(): string
         $message = new RawMessage('');
         $envelope = new MailerEnvelope(new Address('fabien@example.com'), [new Address('helene@example.com')]);
         $mailer->send($message, $envelope);
-        $this->assertTrue(true);
     }
 }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/NotCompromisedPasswordValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/NotCompromisedPasswordValidatorTest.php
@@ -213,8 +213,9 @@ public function testApiError()
      */
     public function testApiErrorSkipped(NotCompromisedPassword $constraint)
     {
+        $this->expectNotToPerformAssertions();
+
         $this->validator->validate(self::PASSWORD_TRIGGERING_AN_ERROR, $constraint);
-        $this->assertTrue(true); // No exception have been thrown
     }
 
     public static function provideErrorSkippingConstraints(): iterable

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ public function testUnsupportedShellOption()`
`53`	`53`
`54`	`54`	`public function testAdditionalShellSupport()`
`55`	`55`	`{`
	`56`	`+ $this->expectNotToPerformAssertions();`
	`57`	`+`
`56`	`58`	`$this->command = new CompleteCommand(['supported' => BashCompletionOutput::class]);`
`57`	`59`	`$this->command->setApplication($this->application);`
`58`	`60`	`$this->tester = new CommandTester($this->command);`
`@@ -61,8 +63,6 @@ public function testAdditionalShellSupport()`
`61`	`63`
`62`	`64`	`// verify that the default set of shells is still supported`
`63`	`65`	`$this->execute(['--shell' => 'bash', '--current' => '1', '--input' => ['bin/console']]);`
`64`		`-`
`65`		`- $this->assertTrue(true);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,10 @@ protected function setUp(): void`
`27`	`27`	`*/`
`28`	`28`	`public function testRewindOnFtp()`
`29`	`29`	`{`
`30`		`- $i = new RecursiveDirectoryIterator('ftp://speedtest:speedtest@ftp.otenet.gr/', \RecursiveDirectoryIterator::SKIP_DOTS);`
	`30`	`+ $this->expectNotToPerformAssertions();`
`31`	`31`
	`32`	`+ $i = new RecursiveDirectoryIterator('ftp://speedtest:speedtest@ftp.otenet.gr/', \RecursiveDirectoryIterator::SKIP_DOTS);`
`32`	`33`	`$i->rewind();`
`33`		`-`
`34`		`- $this->assertTrue(true);`
`35`	`34`	`}`
`36`	`35`
`37`	`36`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,8 @@ public function dispatch($message, array $stamps = []): Envelope`
`86`	`86`
`87`	`87`	`public function testRejectMessage()`
`88`	`88`	`{`
	`89`	`+ $this->expectNotToPerformAssertions();`
	`90`	`+`
`89`	`91`	`$dispatcher = new EventDispatcher();`
`90`	`92`	`$dispatcher->addListener(MessageEvent::class, fn (MessageEvent $event) => $event->reject(), 255);`
`91`	`93`	`$dispatcher->addListener(MessageEvent::class, fn () => throw new \RuntimeException('Should never be called.'));`
`@@ -111,6 +113,5 @@ public function __toString(): string`
`111`	`113`	`$message = new RawMessage('');`
`112`	`114`	`$envelope = new MailerEnvelope(new Address('fabien@example.com'), [new Address('helene@example.com')]);`
`113`	`115`	`$mailer->send($message, $envelope);`
`114`		`- $this->assertTrue(true);`
`115`	`116`	`}`
`116`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -213,8 +213,9 @@ public function testApiError()`
`213`	`213`	`*/`
`214`	`214`	`public function testApiErrorSkipped(NotCompromisedPassword $constraint)`
`215`	`215`	`{`
	`216`	`+ $this->expectNotToPerformAssertions();`
	`217`	`+`
`216`	`218`	`$this->validator->validate(self::PASSWORD_TRIGGERING_AN_ERROR, $constraint);`
`217`		`- $this->assertTrue(true); // No exception have been thrown`
`218`	`219`	`}`
`219`	`220`
`220`	`221`	`public static function provideErrorSkippingConstraints(): iterable`