Skip to content

Replace TestCase::assertTrue(true) with TestCase::expectNotToPerformAssertions() #57792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2024
Merged

Replace TestCase::assertTrue(true) with TestCase::expectNotToPerformAssertions() #57792

merged 1 commit into from
Jul 22, 2024
+8 −7

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Jul 22, 2024
@xabbuh
Copy link
Member

xabbuh commented Jul 22, 2024

Thank you @alexandre-daubois.

@xabbuh xabbuh merged commit 78de59b into symfony:7.2 Jul 22, 2024
4 of 10 checks passed
@alexandre-daubois alexandre-daubois deleted the assert-true branch July 22, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @xabbuh @derrabus @carsonbot