bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)

nicolas-grekas · nicolas-grekas · commit 8b6f56e3805a · 2022-04-21T18:44:18.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Always add CacheCollectorPass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - I don't understand why, in addition to being tied to the `profiler` config being enabled, `CacheCollectorPass` is also tied to `kernel.debug` being true (compared to the other collector passes). My use case is that I use the cache collector data in tests but I don't run the tests in debug mode (for performance). Commits ------- 3fab417 [FrameworkBundle] Always add CacheCollectorPass
diff --git a/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php b/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php
@@ -157,12 +157,12 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new RegisterReverseContainerPass(true));
         $container->addCompilerPass(new RegisterReverseContainerPass(false), PassConfig::TYPE_AFTER_REMOVING);
         $container->addCompilerPass(new SessionPass());
+        $container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);
 
         if ($container->getParameter('kernel.debug')) {
             $container->addCompilerPass(new AddDebugLogProcessorPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 2);
             $container->addCompilerPass(new UnusedTagsPass(), PassConfig::TYPE_AFTER_REMOVING);
             $container->addCompilerPass(new ContainerBuilderDebugDumpPass(), PassConfig::TYPE_BEFORE_REMOVING, -255);
-            $container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -157,12 +157,12 @@ public function build(ContainerBuilder $container)`
`157`	`157`	`$container->addCompilerPass(new RegisterReverseContainerPass(true));`
`158`	`158`	`$container->addCompilerPass(new RegisterReverseContainerPass(false), PassConfig::TYPE_AFTER_REMOVING);`
`159`	`159`	`$container->addCompilerPass(new SessionPass());`
	`160`	`+ $container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);`
`160`	`161`
`161`	`162`	`if ($container->getParameter('kernel.debug')) {`
`162`	`163`	`$container->addCompilerPass(new AddDebugLogProcessorPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 2);`
`163`	`164`	`$container->addCompilerPass(new UnusedTagsPass(), PassConfig::TYPE_AFTER_REMOVING);`
`164`	`165`	`$container->addCompilerPass(new ContainerBuilderDebugDumpPass(), PassConfig::TYPE_BEFORE_REMOVING, -255);`
`165`		`- $container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`