[FrameworkBundle] Always add CacheCollectorPass #46125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Apr 21, 2022
|
Thank you @fancyweb. |
This was referenced Apr 27, 2022
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
May 27, 2022
…ctorPass (fancyweb)" (chalasr) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Revert "bug #46125 Always add CacheCollectorPass (fancyweb)" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #46416 | License | MIT | Doc PR | - This reverts commit 8b6f56e, reversing changes made to fd1c94b. This change appears to be breaking for some, let's rediscuss it on 6.2. Commits ------- 36d6516 Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"
fabpot
added a commit
that referenced
this pull request
May 27, 2022
* 4.4: [DoctrineBridge] Don't reinit managers when they are proxied as ghost objects Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"
fabpot
added a commit
that referenced
this pull request
May 27, 2022
* 5.4: [DoctrineBridge] Don't reinit managers when they are proxied as ghost objects Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"
fabpot
added a commit
that referenced
this pull request
May 27, 2022
* 6.0: [DoctrineBridge] Don't reinit managers when they are proxied as ghost objects Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"
fabpot
added a commit
that referenced
this pull request
May 27, 2022
* 6.1: [DoctrineBridge] Don't reinit managers when they are proxied as ghost objects Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"
This was referenced May 27, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why, in addition to being tied to the
profilerconfig being enabled,CacheCollectorPassis also tied tokernel.debugbeing true (compared to the other collector passes).My use case is that I use the cache collector data in tests but I don't run the tests in debug mode (for performance).