[PropertyAccess] Added reproducer for adder/setter priority #29340 #28966

karser · karser · commit 9559fe98136a · 2018-11-27T13:13:41.000+02:00
diff --git a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestAdderVersusSetter.php b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestAdderVersusSetter.php
@@ -0,0 +1,51 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\PropertyAccess\Tests\Fixtures;
+
+
+class TestAdderVersusSetter
+{
+    /** @var array */
+    private $emails = array();
+
+    /**
+     * @param array $emails
+     */
+    public function setEmails($emails)
+    {
+        throw new \RuntimeException('Setter must NOT be called while adder exists');
+    }
+
+    /**
+     * @return array
+     */
+    public function getEmails()
+    {
+        return $this->emails;
+    }
+
+    /**
+     * @param string $email
+     */
+    public function addEmail($email)
+    {
+        $this->emails[] = $email;
+    }
+
+    /**
+     * @param string $email
+     */
+    public function removeEmail($email)
+    {
+        $this->emails = array_diff($this->emails, array($email));
+    }
+}
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
@@ -16,6 +16,7 @@
 use Symfony\Component\PropertyAccess\Exception\NoSuchIndexException;
 use Symfony\Component\PropertyAccess\PropertyAccessor;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\ReturnTyped;
+use Symfony\Component\PropertyAccess\Tests\Fixtures\TestAdderVersusSetter;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestClass;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestClassIsWritable;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestClassMagicCall;
@@ -722,4 +723,14 @@ public function testWriteToPluralPropertyWhileSingularOneExists()
         self::assertEquals(array('test@email.com'), $object->getEmails());
         self::assertNull($object->getEmail());
     }
+
+    public function testAdderHasHigherPriorityThanPluralSetter()
+    {
+        $object = new TestAdderVersusSetter();
+
+        $this->propertyAccessor->isWritable($object, 'emails'); //cache access info
+        $this->propertyAccessor->setValue($object, 'emails', array('test@email.com'));
+
+        self::assertEquals(array('test@email.com'), $object->getEmails());
+    }
 }
