[PropertyAccessor] Fix unable to write to singular property using setter while plural adder/remover exist #28966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter while plural adder/remover exist
nicolas-grekas
approved these changes
Oct 31, 2018
|
@nicolas-grekas This bug exists in 4.1 and master, is this PR going to be merged in there as well? |
|
@karser yes: we regularly merge lower branches into upper ones. |
|
Thank you @karser. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 15, 2018
…y using setter while plural adder/remover exist (karser) This PR was merged into the 3.4 branch. Discussion ---------- [PropertyAccessor] Fix unable to write to singular property using setter while plural adder/remover exist | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28961 | License | MIT Please take a look at the tests I added - they describe the issue. It has to do with the priorities: `findAdderAndRemover('User', 'email')` is called earlier than `$this->isMethodAccessible('User', 'setEmail', 1)` Commits ------- 8238f16 [PropertyAccessor] Fix unable to write to singular property using setter while plural adder/remover exist
Merged
|
I think we have a problem here which has caused a regression, or at least a change in behaviour. If you have a collection property which has a setter, an adder and a remover: class Foo
{
private $invoices = [];
public function setInvoices(array $invoices): void
{
//...
}
public function addInvoice(Invoice $invoice): void
{
//...
}
public function removeInvoice(Invoice $item): void
{
//...
}
}prior to this change, the adder/remover were used over the setter, but with this change, the setter is prioritized over the adder/remover. Yes, Is this an intended, acceptable consequence? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look at the tests I added - they describe the issue. It has to do with the priorities:
findAdderAndRemover('User', 'email')is called earlier than$this->isMethodAccessible('User', 'setEmail', 1)