bug #42274 [VarDumper] HtmlDumper::setDumpHeader() accepts null (rrpadilla)

derrabus · derrabus · commit a1055aef8359 · 2021-07-28T09:58:40.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [VarDumper] `HtmlDumper::setDumpHeader()` accepts `null` | Q | A | ------------- | --- | Branch? | 5.3  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #42272  | License | MIT | Doc PR | symfony/symfony-docs#...   Commits ------- 98447a9 HtmlDumper - setDumpHeader accepts null
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -117,7 +117,7 @@ public function setDisplayOptions(array $displayOptions)
     /**
      * Sets an HTML header that will be dumped once in the output stream.
      */
-    public function setDumpHeader(string $header)
+    public function setDumpHeader(?string $header)
     {
         $this->dumpHeader = $header;
     }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public function setDisplayOptions(array $displayOptions)`
`117`	`117`	`/**`
`118`	`118`	`* Sets an HTML header that will be dumped once in the output stream.`
`119`	`119`	`*/`
`120`		`- public function setDumpHeader(string $header)`
	`120`	`+ public function setDumpHeader(?string $header)`
`121`	`121`	`{`
`122`	`122`	`$this->dumpHeader = $header;`
`123`	`123`	`}`