-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[VarDumper] HtmlDumper::setDumpHeader()
accepts null
#42274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rrpadilla
commented
Jul 27, 2021
Q | A |
---|---|
Branch? | 5.3 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #42272 |
License | MIT |
Doc PR | symfony/symfony-docs#... |
Shouldn't maximebf/debugbar be patched instead? Can you please them a PR? |
I read that in the issue on maximebf/debugbar, found the corresponding line in the code. This makes sense as a big fix now. Can you please add a test case to back the behavior up? |
I suggested an alternate fix in php-debugbar/php-debugbar#474 |
I fixed it for the time being now: php-debugbar/php-debugbar#475 I think we needed to reset it for a reason, which isn't currently possible. We're now overriding this method which solves it, but either a nullable check or a reset method would be helpful. |
Do you want to contribute the reset method as a feature for 5.4? |
Actually I prefer making the setter null able as a bugfix :) |
HtmlDumper::setDumpHeader()
accepts null
Good catch, thanks @rrpadilla. |