[Notifier] Clean unused code

alamirault · alamirault · commit b3941dfcd7a3 · 2023-11-16T21:53:53.000+01:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Mercure/MercureTransport.php b/src/Symfony/Component/Notifier/Bridge/Mercure/MercureTransport.php
@@ -48,7 +48,7 @@ public function __construct(HubInterface $hub, string $hubId, string|array $topi
 
     public function __toString(): string
     {
-        return sprintf('mercure://%s%s', $this->hubId, null !== $this->topics ? '?'.http_build_query(['topic' => $this->topics], '', '&') : '');
+        return sprintf('mercure://%s%s', $this->hubId, '?'.http_build_query(['topic' => $this->topics], '', '&'));
     }
 
     public function supports(MessageInterface $message): bool
diff --git a/src/Symfony/Component/Notifier/Bridge/Telnyx/TelnyxTransport.php b/src/Symfony/Component/Notifier/Bridge/Telnyx/TelnyxTransport.php
@@ -67,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage
         if (!preg_match('/^[+]+[1-9][0-9]{9,14}$/', $from)) {
             if ('' === $from) {
                 throw new IncompleteDsnException('This phone number is invalid.');
-            } elseif ('' !== $from && null === $this->messagingProfileId) {
+            } elseif (null === $this->messagingProfileId) {
                 throw new IncompleteDsnException('The sending messaging profile must be specified.');
             }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function __construct(HubInterface $hub, string $hubId, string\|array $topi`
`48`	`48`
`49`	`49`	`public function __toString(): string`
`50`	`50`	`{`
`51`		`- return sprintf('mercure://%s%s', $this->hubId, null !== $this->topics ? '?'.http_build_query(['topic' => $this->topics], '', '&') : '');`
	`51`	`+ return sprintf('mercure://%s%s', $this->hubId, '?'.http_build_query(['topic' => $this->topics], '', '&'));`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`public function supports(MessageInterface $message): bool`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage`
`67`	`67`	`if (!preg_match('/^[+]+[1-9][0-9]{9,14}$/', $from)) {`
`68`	`68`	`if ('' === $from) {`
`69`	`69`	`throw new IncompleteDsnException('This phone number is invalid.');`
`70`		`- } elseif ('' !== $from && null === $this->messagingProfileId) {`
	`70`	`+ } elseif (null === $this->messagingProfileId) {`
`71`	`71`	`throw new IncompleteDsnException('The sending messaging profile must be specified.');`
`72`	`72`	`}`
`73`	`73`