Convert to yoda condition

lawsonjl-ornl · web-flow · commit bf8cbbd6ad7f · 2024-01-19T10:51:25.000-05:00
diff --git a/src/Symfony/Component/Console/Input/InputOption.php b/src/Symfony/Component/Console/Input/InputOption.php
@@ -81,7 +81,7 @@ public function __construct(string $name, $shortcut = null, int $mode = null, st
             $shortcuts = array_filter($shortcuts, 'strlen');
             $shortcut = implode('|', $shortcuts);
 
-            if ($shortcut === '') {
+            if ('' === $shortcut) {
                 throw new InvalidArgumentException('An option shortcut cannot be empty.');
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ public function __construct(string $name, $shortcut = null, int $mode = null, st`
`81`	`81`	`$shortcuts = array_filter($shortcuts, 'strlen');`
`82`	`82`	`$shortcut = implode('\|', $shortcuts);`
`83`	`83`
`84`		`- if ($shortcut === '') {`
	`84`	`+ if ('' === $shortcut) {`
`85`	`85`	`throw new InvalidArgumentException('An option shortcut cannot be empty.');`
`86`	`86`	`}`
`87`	`87`	`}`