[String] Fix AsciiSlugger with emojis

fancyweb · fancyweb · commit c4b97d761710 · 2022-11-29T19:49:19.000+01:00
diff --git a/src/Symfony/Component/String/Slugger/AsciiSlugger.php b/src/Symfony/Component/String/Slugger/AsciiSlugger.php
@@ -113,10 +113,8 @@ public function slug(string $string, string $separator = '-', string $locale = n
             $transliterator = (array) $this->createTransliterator($locale);
         }
 
-        if (\is_string($this->emoji)) {
-            $transliterator[] = EmojiTransliterator::create("emoji-{$this->emoji}");
-        } elseif ($this->emoji && null !== $locale) {
-            $transliterator[] = EmojiTransliterator::create("emoji-{$locale}");
+        if ($emojiTransliterator = $this->createEmojiTransliterator(\is_string($this->emoji) ? $this->emoji : ($this->emoji && null !== $locale ? $locale : null))) {
+            $transliterator[] = $emojiTransliterator;
         }
 
         if ($this->symbolsMap instanceof \Closure) {
@@ -177,6 +175,19 @@ private function createTransliterator(string $locale): ?\Transliterator
         return $this->transliterators[$locale] = $this->transliterators[$parent] = $transliterator ?? null;
     }
 
+    private function createEmojiTransliterator(?string $locale): ?EmojiTransliterator
+    {
+        while (null !== $locale) {
+            try {
+                return EmojiTransliterator::create("emoji-$locale");
+            } catch (\IntlException) {
+                $locale = self::getParentLocale($locale);
+            }
+        }
+
+        return null;
+    }
+
     private static function getParentLocale(?string $locale): ?string
     {
         if (!$locale) {
diff --git a/src/Symfony/Component/String/Tests/Slugger/AsciiSluggerTest.php b/src/Symfony/Component/String/Tests/Slugger/AsciiSluggerTest.php
@@ -94,5 +94,15 @@ public function provideSlugEmojiTests(): iterable
             'en',
             'github',
         ];
+        yield [
+            'un-chat-qui-sourit-chat-noir-et-un-tete-de-lion-vont-au-parc-national',
+            'un 😺, 🐈‍⬛, et un 🦁 vont au 🏞️',
+            'fr_XX', // Fallback on parent locale
+        ];
+        yield [
+            'un-et-un-vont-au',
+            'un 😺, 🐈‍⬛, et un 🦁 vont au 🏞️',
+            'undefined_locale', // Behaves the same as if emoji support is disabled
+        ];
     }
 }
