Fix infinite recursion when passed an empty string

corphi · corphi · commit c537c854c72e · 2019-01-27T23:49:26.000+01:00
diff --git a/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php b/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
@@ -42,8 +42,9 @@ class AccessDecisionManager implements AccessDecisionManagerInterface
      */
     public function __construct($voters = [], $strategy = self::STRATEGY_AFFIRMATIVE, $allowIfAllAbstainDecisions = false, $allowIfEqualGrantedDeniedDecisions = true)
     {
+        $strategy = (string) $strategy;
         $strategyMethod = 'decide'.ucfirst($strategy);
-        if (!\is_callable([$this, $strategyMethod])) {
+        if (!\is_callable([$this, $strategyMethod]) || 0 === \strlen($strategy)) {
             throw new \InvalidArgumentException(sprintf('The strategy "%s" is not supported.', $strategy));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,9 @@ class AccessDecisionManager implements AccessDecisionManagerInterface`
`42`	`42`	`*/`
`43`	`43`	`public function __construct($voters = [], $strategy = self::STRATEGY_AFFIRMATIVE, $allowIfAllAbstainDecisions = false, $allowIfEqualGrantedDeniedDecisions = true)`
`44`	`44`	`{`
	`45`	`+ $strategy = (string) $strategy;`
`45`	`46`	`$strategyMethod = 'decide'.ucfirst($strategy);`
`46`		`- if (!\is_callable([$this, $strategyMethod])) {`
	`47`	`+ if (!\is_callable([$this, $strategyMethod]) \|\| 0 === \strlen($strategy)) {`
`47`	`48`	`throw new \InvalidArgumentException(sprintf('The strategy "%s" is not supported.', $strategy));`
`48`	`49`	`}`
`49`	`50`