feature #24080 Deprecated the web_profiler.position option (javiereguiluz)

fabpot · fabpot · commit c97c6d48b347 · 2017-09-07T08:02:00.000-07:00
This PR was squashed before being merged into the 3.4 branch (closes #24080). Discussion ---------- Deprecated the web_profiler.position option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no  | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #23528 | License | MIT | Doc PR | - Related to #23728, which removes the feature for Symfony 4.0. Commits ------- 53387b4 Deprecated the web_profiler.position option
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -53,6 +53,8 @@ CHANGELOG
    `EventDispatcherDebugCommand`, `RouterDebugCommand`, `RouterMatchCommand`,
    `TranslationDebugCommand`, `TranslationUpdateCommand`, `XliffLintCommand`
     and `YamlLintCommand` classes have been marked as final
+ * Deprecated the `web_profiler.position` config option (in Symfony 4.0 the toolbar
+   will always be displayed at the bottom).
 
 3.3.0
 -----
diff --git a/src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php
@@ -39,6 +39,7 @@ public function getConfigTreeBuilder()
                 ->booleanNode('toolbar')->defaultFalse()->end()
                 ->scalarNode('position')
                     ->defaultValue('bottom')
+                    ->setDeprecated('The "web_profiler.position" configuration key has been deprecated in Symfony 3.4 and it will be removed in 4.0.')
                     ->validate()
                         ->ifNotInArray(array('bottom', 'top'))
                         ->thenInvalid('The CSS position %s is not supported')
