Apply suggestions from code review

OskarStark · web-flow · commit d0143d82e4fd · 2023-12-20T23:53:57.000+01:00
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
@@ -53,7 +53,7 @@ public function testExpectsStringCompatibleType()
         $this->validator->validate(new \stdClass(), new Length(['value' => 5]));
     }
 
-    public static function getThreeOrLessCharacters(): array
+    public static function getThreeOrLessCharacters()
     {
         return [
             [12, 2],
@@ -67,7 +67,7 @@ public static function getThreeOrLessCharacters(): array
         ];
     }
 
-    public static function getFourCharacters(): array
+    public static function getFourCharacters()
     {
         return [
             [1234],
@@ -77,7 +77,7 @@ public static function getFourCharacters(): array
         ];
     }
 
-    public static function getFiveOrMoreCharacters(): array
+    public static function getFiveOrMoreCharacters()
     {
         return [
             [12345, 5],
@@ -91,7 +91,7 @@ public static function getFiveOrMoreCharacters(): array
         ];
     }
 
-    public static function getOneCharset(): array
+    public static function getOneCharset()
     {
         return [
             ['é', 'utf8', true],
@@ -101,7 +101,7 @@ public static function getOneCharset(): array
         ];
     }
 
-    public static function getThreeCharactersWithWhitespaces(): array
+    public static function getThreeCharactersWithWhitespaces()
     {
         return [
             ["\x20ccc"],
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/LocaleValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/LocaleValidatorTest.php
@@ -53,7 +53,7 @@ public function testValidLocales($locale)
         $this->assertNoViolation();
     }
 
-    public static function getValidLocales(): array
+    public static function getValidLocales()
     {
         return [
             ['en'],
@@ -83,7 +83,7 @@ public function testInvalidLocales($locale)
             ->assertRaised();
     }
 
-    public static function getInvalidLocales(): array
+    public static function getInvalidLocales()
     {
         return [
             ['baz'],

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function testExpectsStringCompatibleType()`
`53`	`53`	`$this->validator->validate(new \stdClass(), new Length(['value' => 5]));`
`54`	`54`	`}`
`55`	`55`
`56`		`- public static function getThreeOrLessCharacters(): array`
	`56`	`+ public static function getThreeOrLessCharacters()`
`57`	`57`	`{`
`58`	`58`	`return [`
`59`	`59`	`[12, 2],`
`@@ -67,7 +67,7 @@ public static function getThreeOrLessCharacters(): array`
`67`	`67`	`];`
`68`	`68`	`}`
`69`	`69`
`70`		`- public static function getFourCharacters(): array`
	`70`	`+ public static function getFourCharacters()`
`71`	`71`	`{`
`72`	`72`	`return [`
`73`	`73`	`[1234],`
`@@ -77,7 +77,7 @@ public static function getFourCharacters(): array`
`77`	`77`	`];`
`78`	`78`	`}`
`79`	`79`
`80`		`- public static function getFiveOrMoreCharacters(): array`
	`80`	`+ public static function getFiveOrMoreCharacters()`
`81`	`81`	`{`
`82`	`82`	`return [`
`83`	`83`	`[12345, 5],`
`@@ -91,7 +91,7 @@ public static function getFiveOrMoreCharacters(): array`
`91`	`91`	`];`
`92`	`92`	`}`
`93`	`93`
`94`		`- public static function getOneCharset(): array`
	`94`	`+ public static function getOneCharset()`
`95`	`95`	`{`
`96`	`96`	`return [`
`97`	`97`	`['é', 'utf8', true],`
`@@ -101,7 +101,7 @@ public static function getOneCharset(): array`
`101`	`101`	`];`
`102`	`102`	`}`
`103`	`103`
`104`		`- public static function getThreeCharactersWithWhitespaces(): array`
	`104`	`+ public static function getThreeCharactersWithWhitespaces()`
`105`	`105`	`{`
`106`	`106`	`return [`
`107`	`107`	`["\x20ccc"],`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function testValidLocales($locale)`
`53`	`53`	`$this->assertNoViolation();`
`54`	`54`	`}`
`55`	`55`
`56`		`- public static function getValidLocales(): array`
	`56`	`+ public static function getValidLocales()`
`57`	`57`	`{`
`58`	`58`	`return [`
`59`	`59`	`['en'],`
`@@ -83,7 +83,7 @@ public function testInvalidLocales($locale)`
`83`	`83`	`->assertRaised();`
`84`	`84`	`}`
`85`	`85`
`86`		`- public static function getInvalidLocales(): array`
	`86`	`+ public static function getInvalidLocales()`
`87`	`87`	`{`
`88`	`88`	`return [`
`89`	`89`	`['baz'],`