bug #33282 [HttpKernel] Do not extend the new SF 4.3 ControllerEvent so we can make it final (Tobion)

nicolas-grekas · nicolas-grekas · commit dd153d8dcef4 · 2019-08-21T16:59:28.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [HttpKernel] Do not extend the new SF 4.3 ControllerEvent so we can make it final | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no  | BC breaks? | unlikely | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | | License | MIT | Doc PR | See #33152 (comment) Remember the ControllerEvent is new in SF 4.3 so we just go back to what it was before 4.3 Commits ------- 00140b6 Do not extend the new SF 4.3 ControllerEvent so we can make it final
diff --git a/src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php b/src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php
@@ -17,7 +17,7 @@
 /**
  * @deprecated since Symfony 4.3, use ControllerArgumentsEvent instead
  */
-class FilterControllerArgumentsEvent extends ControllerEvent
+class FilterControllerArgumentsEvent extends FilterControllerEvent
 {
     private $arguments;
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`/**`
`18`	`18`	`* @deprecated since Symfony 4.3, use ControllerArgumentsEvent instead`
`19`	`19`	`*/`
`20`		`-class FilterControllerArgumentsEvent extends ControllerEvent`
	`20`	`+class FilterControllerArgumentsEvent extends FilterControllerEvent`
`21`	`21`	`{`
`22`	`22`	`private $arguments;`
`23`	`23`