[Security] [Guard] Added type-hints to AuthenticatorInterface

thomasbisignani · thomasbisignani · commit f44532943f24 · 2019-06-30T11:29:02.000+02:00
diff --git a/src/Symfony/Component/Security/Guard/AbstractGuardAuthenticator.php b/src/Symfony/Component/Security/Guard/AbstractGuardAuthenticator.php
@@ -26,11 +26,10 @@ abstract class AbstractGuardAuthenticator implements AuthenticatorInterface
      * care about which authenticated token you're using.
      *
      * @param UserInterface $user
-     * @param string        $providerKey
      *
      * @return PostAuthenticationGuardToken
      */
-    public function createAuthenticatedToken(UserInterface $user, $providerKey)
+    public function createAuthenticatedToken(UserInterface $user, string $providerKey)
     {
         return new PostAuthenticationGuardToken(
             $user,
diff --git a/src/Symfony/Component/Security/Guard/AuthenticatorInterface.php b/src/Symfony/Component/Security/Guard/AuthenticatorInterface.php
@@ -113,11 +113,10 @@ public function checkCredentials($credentials, UserInterface $user);
      * @see AbstractGuardAuthenticator
      *
      * @param UserInterface $user
-     * @param string        $providerKey The provider (i.e. firewall) key
      *
      * @return GuardTokenInterface
      */
-    public function createAuthenticatedToken(UserInterface $user, $providerKey);
+    public function createAuthenticatedToken(UserInterface $user, string $providerKey);
 
     /**
      * Called when authentication executed, but failed (e.g. wrong username password).
@@ -146,11 +145,10 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
      *
      * @param Request        $request
      * @param TokenInterface $token
-     * @param string         $providerKey The provider (i.e. firewall) key
      *
      * @return Response|null
      */
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey);
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey);
 
     /**
      * Does this method support remember me cookies?
diff --git a/src/Symfony/Component/Security/Guard/Tests/Authenticator/FormLoginAuthenticatorTest.php b/src/Symfony/Component/Security/Guard/Tests/Authenticator/FormLoginAuthenticatorTest.php
@@ -103,7 +103,7 @@ public function supports(Request $request)
         return true;
     }
 
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey)
     {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,10 @@ abstract class AbstractGuardAuthenticator implements AuthenticatorInterface`
`26`	`26`	`* care about which authenticated token you're using.`
`27`	`27`	`*`
`28`	`28`	`* @param UserInterface $user`
`29`		`- * @param string $providerKey`
`30`	`29`	`*`
`31`	`30`	`* @return PostAuthenticationGuardToken`
`32`	`31`	`*/`
`33`		`- public function createAuthenticatedToken(UserInterface $user, $providerKey)`
	`32`	`+ public function createAuthenticatedToken(UserInterface $user, string $providerKey)`
`34`	`33`	`{`
`35`	`34`	`return new PostAuthenticationGuardToken(`
`36`	`35`	`$user,`
Original file line number	Diff line number	Diff line change
`@@ -113,11 +113,10 @@ public function checkCredentials($credentials, UserInterface $user);`
`113`	`113`	`* @see AbstractGuardAuthenticator`
`114`	`114`	`*`
`115`	`115`	`* @param UserInterface $user`
`116`		`- * @param string $providerKey The provider (i.e. firewall) key`
`117`	`116`	`*`
`118`	`117`	`* @return GuardTokenInterface`
`119`	`118`	`*/`
`120`		`- public function createAuthenticatedToken(UserInterface $user, $providerKey);`
	`119`	`+ public function createAuthenticatedToken(UserInterface $user, string $providerKey);`
`121`	`120`
`122`	`121`	`/**`
`123`	`122`	`* Called when authentication executed, but failed (e.g. wrong username password).`
`@@ -146,11 +145,10 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`146`	`145`	`*`
`147`	`146`	`* @param Request $request`
`148`	`147`	`* @param TokenInterface $token`
`149`		`- * @param string $providerKey The provider (i.e. firewall) key`
`150`	`148`	`*`
`151`	`149`	`* @return Response\|null`
`152`	`150`	`*/`
`153`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey);`
	`151`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey);`
`154`	`152`
`155`	`153`	`/**`
`156`	`154`	`* Does this method support remember me cookies?`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function supports(Request $request)`
`103`	`103`	`return true;`
`104`	`104`	`}`
`105`	`105`
`106`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)`
	`106`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey)`
`107`	`107`	`{`
`108`	`108`	`}`
`109`	`109`