[VarDumper] Ignore \Error in __debugInfo()

fancyweb · fancyweb · commit fc84f11e3a80 · 2022-11-28T12:50:21.000+01:00
diff --git a/src/Symfony/Component/VarDumper/Caster/Caster.php b/src/Symfony/Component/VarDumper/Caster/Caster.php
@@ -50,7 +50,7 @@ public static function castObject($obj, string $class, bool $hasDebugInfo = fals
         if ($hasDebugInfo) {
             try {
                 $debugInfo = $obj->__debugInfo();
-            } catch (\Exception $e) {
+            } catch (\Throwable $e) {
                 // ignore failing __debugInfo()
                 $hasDebugInfo = false;
             }
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/CasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/CasterTest.php
@@ -175,4 +175,14 @@ class@anonymous {
             , $c
         );
     }
+
+    public function testTypeErrorInDebugInfo()
+    {
+        $this->assertDumpMatchesFormat('class@anonymous {}', new class {
+            public function __debugInfo(): array
+            {
+                return ['class' => get_class(null)];
+            }
+        });
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public static function castObject($obj, string $class, bool $hasDebugInfo = fals`
`50`	`50`	`if ($hasDebugInfo) {`
`51`	`51`	`try {`
`52`	`52`	`$debugInfo = $obj->__debugInfo();`
`53`		`- } catch (\Exception $e) {`
	`53`	`+ } catch (\Throwable $e) {`
`54`	`54`	`// ignore failing __debugInfo()`
`55`	`55`	`$hasDebugInfo = false;`
`56`	`56`	`}`