Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.0-BETA3
Choose a base ref
...
head repository: symfony/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.0
Choose a head ref
  • 10 commits
  • 25 files changed
  • 4 contributors

Commits on May 26, 2018

  1. Configuration menu
    Copy the full SHA
    62adf93 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2018

  1. Configuration menu
    Copy the full SHA
    744362a View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. minor #27393 [Form] mention "help" field option in UPGRADE file (mhujer)

    This PR was merged into the 4.1 branch.
    
    Discussion
    ----------
    
    [Form] mention "help" field option in UPGRADE file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.1 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    
    When you have your own Form Extension to handle help option (e.g. similar to the one mentioned in the [blog post](https://symfony.com/blog/new-in-symfony-4-1-form-field-help)), it starts to render twice in the form after upgrading to 4.1 (where #26332 was added)
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    744362a update UPGRADE-4.1 for feature #26332 Form field help option
    nicolas-grekas committed May 29, 2018
    Configuration menu
    Copy the full SHA
    e0ec1f3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)"

    This reverts commit 9fda6d3, reversing
    changes made to ca53d3e.
    nicolas-grekas committed May 30, 2018
    Configuration menu
    Copy the full SHA
    2ddb89b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37270d7 View commit details
    Browse the repository at this point in the history
  3. bug #27415 Insert correct parameter_bag service in AbstractController…

    … (curry684)
    
    This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes #27415).
    
    Discussion
    ----------
    
    Insert correct parameter_bag service in AbstractController
    
    Reverts this feature being broken in 3051289#diff-ef10778bc68793f8c8f4b71a7ba67790R86 - `getParameter` could never work now as it was querying the container itself instead of the parameter bag.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | License       | MIT
    
    Also see comments at #25439 (comment)
    
    Commits
    -------
    
    37270d7 Insert correct parameter_bag service in AbstractController
    nicolas-grekas committed May 30, 2018
    Configuration menu
    Copy the full SHA
    ce616bf View commit details
    Browse the repository at this point in the history
  4. bug #27420 Revert "feature #26702 Mark ExceptionInterfaces throwable …

    …(ostrolucky)" (nicolas-grekas)
    
    This PR was merged into the 4.1 branch.
    
    Discussion
    ----------
    
    Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)"
    
    This reverts commit 9fda6d3, reversing
    changes made to ca53d3e.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #27419
    | License       | MIT
    | Doc PR        | -
    
    #26702 introduced a BC break.
    
    Commits
    -------
    
    2ddb89b Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)"
    nicolas-grekas committed May 30, 2018
    Configuration menu
    Copy the full SHA
    79adbcc View commit details
    Browse the repository at this point in the history
  5. updated CHANGELOG for 4.1.0

    fabpot committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1442c42 View commit details
    Browse the repository at this point in the history
  6. updated VERSION for 4.1.0

    fabpot committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1d9e422 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #27424 from fabpot/release-4.1.0

    released v4.1.0
    fabpot authored May 30, 2018
    Configuration menu
    Copy the full SHA
    5826104 View commit details
    Browse the repository at this point in the history
Loading