Skip to content

[FrameworkBundle] The resource type of the default router is not overridable #11018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lavoiesl opened this issue May 30, 2014 · 2 comments
Closed

[FrameworkBundle] The resource type of the default router is not overridable #11018

lavoiesl opened this issue May 30, 2014 · 2 comments
Labels
FrameworkBundle

Comments

@lavoiesl
Copy link
Contributor

It is possible to change the router.resource parameter, but the resource type option is unavailable, making it impossible to override it without manipulating the Service Definition. If the resource file is changeable, I believe the resource type should be as well.

Service definition:

symfony/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml

Line 59 in 76ccb28

<argument type="collection">

Compiler pass:

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Line 311 in 76ccb28

$router = $container->findDefinition('router.default');

Reverse issue : symfony/AsseticBundle#289
@lavoiesl lavoiesl mentioned this issue May 30, 2014
Merged
@wouterj
Copy link
Member

wouterj commented Jun 17, 2015

The resource type option is available and is called type. See https://github.com/symfony/symfony/blob/76ccb280fbb966d3d1c612a8dff600cc2228bc58/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L314-316 and http://symfony.com/doc/current/reference/configuration/framework.html#type

@xabbuh xabbuh closed this as completed Jun 17, 2015
@xabbuh
Copy link
Member

xabbuh commented Jun 17, 2015

Closing as this is no bug as explained by @wouterj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wouterj @lavoiesl @xabbuh