[HttpKernel] Unused method isClassInActiveBundle #11652
Labels
Comments
|
I think this is a left-over from an earlier version of the kernel, at the very beginning of Symfony 2 development, which was missed when we stopped using it. I suggest deprecating it though. I don't see much use case for it. What do you think @fabpot ? |
|
I’ll submit a PR for master to mark it as deprecated for 2.6 within a couple of days. |
|
Ok to deprecate that. |
hacfi
added a commit
to hacfi/symfony
that referenced
this issue
Sep 6, 2014
hacfi
added a commit
to hacfi/symfony
that referenced
this issue
Sep 7, 2014
…:isClassInActiveBundle
hacfi
added a commit
to hacfi/symfony
that referenced
this issue
Sep 8, 2014
hacfi
added a commit
to hacfi/symfony
that referenced
this issue
Sep 8, 2014
fabpot
pushed a commit
that referenced
this issue
Sep 8, 2014
fabpot
added a commit
that referenced
this issue
Sep 8, 2014
…ssInActiveBundle (hacfi) This PR was squashed before being merged into the 2.6-dev branch (closes #11869). Discussion ---------- #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, deprecation targets 3.0 | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Commits ------- 86873f2 #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
fabpot
pushed a commit
that referenced
this issue
Sep 8, 2014
fabpot
added a commit
that referenced
this issue
Sep 8, 2014
…ssInActiveBundle (hacfi) This PR was squashed before being merged into the 2.6-dev branch (closes #11869). Discussion ---------- #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, deprecation targets 3.0 | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Commits ------- a777fd7 #11652 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
This was referenced Dec 4, 2014
fabpot
added a commit
that referenced
this issue
Dec 8, 2014
…tiveBundle() (hacfi) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Add deprecation log for Kernel::isClassInActiveBundle() | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) See #11869 and #12854 Commits ------- 5ba6d1f [HttpKernel] Add deprecation log for Kernel::isClassInActiveBundle()
fabpot
added a commit
that referenced
this issue
Dec 20, 2014
…InActiveBundle (hacfi) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][HttpKernel] Remove unused method Kernel::isClassInActiveBundle | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes, if using isClassInActiveBundle (not used by Symfony itself) | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11652 | License | MIT | Doc PR | - (Not mentioned in the docs) Follow-up of #11869 Commits ------- 91dcca4 [HttpKernel] Remove unused method Kernel::isClassInActiveBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Browsing through the code I noticed that
Symfony\Component\HttpKernel\KernelInterfaceandSymfony\Component\HttpKernel\Kernelhave a method calledisClassInActiveBundlewhich doesn’t seem to be used anywhere. I know it’s marked as api but I was wondering if we really need it or if it was overlooked during refactoring.The text was updated successfully, but these errors were encountered: