Skip to content

[Hackday] [2.7] Add a deprecation note about FormIntegrationTestCase and FormPerformanceTestCase #12606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Nov 29, 2014 · 7 comments

Comments

@javiereguiluz
Copy link
Member

NOTE: This issue is part of the "SymfonyCon 2014 Madrid Hackday" effort to add logs for every 2.7 deprecated feature. This is needed before removing those features in 3.0 version. Please, add you name in a comment of this issue if you are going to work on this.


The FormIntegrationTestCase and FormPerformanceTestCase classes were moved form the Symfony\Component\Form\Tests namespace to the Symfony\Component\Form\Test namespace.

@csuarez
Copy link
Contributor

csuarez commented Nov 29, 2014

I'll try this :)

@csuarez
Copy link
Contributor

csuarez commented Nov 29, 2014

Hi Javier. When you talk about to "to add logs", what do you refer to? Because the @deprecated tag is already in Symfony\Compontent\Form\Tests\FormIntegrationTestCase and Symfony\Component\Form\Tests\FormPerformanceTestCase

@lenardpalko
Copy link

I'm guessing that you could add trigger_error method call in the constructors of these classes, noting when it was deprecated, when it will be removed and what you can use instead.

@csuarez
Copy link
Contributor

csuarez commented Nov 29, 2014

Thank you very much :)

2014-11-29 11:36 GMT+01:00 lenardpalko notifications@github.com:

I'm guessing that you could add trigger_error method call in the
constructors of these classes, noting when it was deprecated, when it will
be removed and what you can use instead.


Reply to this email directly or view it on GitHub
#12606 (comment).

@aferrandini
Copy link
Contributor

If you need it, this Gist explains how to generate the deprecation note:

https://gist.github.com/javiereguiluz/a5514ec6cde2a63be441

@csuarez
Copy link
Contributor

csuarez commented Nov 29, 2014

Thank you @aferrandini :D

@csuarez
Copy link
Contributor

csuarez commented Nov 29, 2014

PR: #12680

fabpot pushed a commit that referenced this issue Nov 30, 2014
fabpot added a commit that referenced this issue Nov 30, 2014
…f [...]/Tests/FormIntegration... (csuarez)

This PR was squashed before being merged into the 2.7 branch (closes #12680).

Discussion
----------

Issue #12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration...

This fixes Issue #12606

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #12606
| License       | MIT
| Doc PR        | x

Commits
-------

2267749 Issue #12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration...
@fabpot fabpot closed this as completed Nov 30, 2014
fabpot added a commit that referenced this issue Dec 2, 2014
* 2.7: (65 commits)
  Configure firewall's kernel exception listener with configured entry point or a default entry point
  PSR-2 fixes
  [DependencyInjection] make paths relative to __DIR__ in the generated container
  [FrameworkBundle][Router Cmd] use debug namespace.
  [FrameworkBundle] Update deprecated service call
  Fix PHP Fatal error:  Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37
  Removed a dev annotation from a version constraint
  Fixed the syntax of a composer.json file
  Fixed the symfony/config version constraint
  Tweaked the password-compat version constraint
  Docblock fixes
  Append to PR #12737 referring Ticket #12704
  Issue #12658 Add a deprecation note about Translator's setFallbackLocale...
  Issue #12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration...
  Hackday deprecated 12621
  Added deprecation log for validate and validateValue on ExecutionContext...
  [Console] [Hackday] [2.7]  Add a deprecation note about ProgressHelper
  [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method
  [Validator] Added a deprecation note about setPropertyAccessor #12698
  [Locale] Adding a deprecation note about the Locale component
  ...
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
* 2.7: (65 commits)
  Configure firewall's kernel exception listener with configured entry point or a default entry point
  PSR-2 fixes
  [DependencyInjection] make paths relative to __DIR__ in the generated container
  [FrameworkBundle][Router Cmd] use debug namespace.
  [FrameworkBundle] Update deprecated service call
  Fix PHP Fatal error:  Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37
  Removed a dev annotation from a version constraint
  Fixed the syntax of a composer.json file
  Fixed the symfony/config version constraint
  Tweaked the password-compat version constraint
  Docblock fixes
  Append to PR symfony#12737 referring Ticket symfony#12704
  Issue symfony#12658 Add a deprecation note about Translator's setFallbackLocale...
  Issue symfony#12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration...
  Hackday deprecated 12621
  Added deprecation log for validate and validateValue on ExecutionContext...
  [Console] [Hackday] [2.7]  Add a deprecation note about ProgressHelper
  [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method
  [Validator] Added a deprecation note about setPropertyAccessor symfony#12698
  [Locale] Adding a deprecation note about the Locale component
  ...
jderusse pushed a commit to jderusse/symfony that referenced this issue Dec 15, 2020
* 2.7: (65 commits)
  Configure firewall's kernel exception listener with configured entry point or a default entry point
  PSR-2 fixes
  [DependencyInjection] make paths relative to __DIR__ in the generated container
  [FrameworkBundle][Router Cmd] use debug namespace.
  [FrameworkBundle] Update deprecated service call
  Fix PHP Fatal error:  Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37
  Removed a dev annotation from a version constraint
  Fixed the syntax of a composer.json file
  Fixed the symfony/config version constraint
  Tweaked the password-compat version constraint
  Docblock fixes
  Append to PR symfony#12737 referring Ticket symfony#12704
  Issue symfony#12658 Add a deprecation note about Translator's setFallbackLocale...
  Issue symfony#12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration...
  Hackday deprecated 12621
  Added deprecation log for validate and validateValue on ExecutionContext...
  [Console] [Hackday] [2.7]  Add a deprecation note about ProgressHelper
  [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method
  [Validator] Added a deprecation note about setPropertyAccessor symfony#12698
  [Locale] Adding a deprecation note about the Locale component
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants