[form] error when submitting empty value in for using model choice list #14583

piogrek · 2015-05-07T22:51:00Z

I think that's happening only on propel + postgres after @webmozart removed empty/null checks from ChoiceToValueTransformer in 1d89922

ModelChoiceList->getChoicesForValues allows to create Propel query with empty string values which are not accepted, so I'm getting:

Unable to execute SELECT statement [SELECT (...) FROM twilio_number WHERE twilio_number.id IN (:p1)] [wrapped: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: ""]

the code below (for propel bridge) seems to do the trick, but I'm not sure if I can create PR for the Propel1Bridge repository. Will appreciate any help.

class ModelChoiceList extends ObjectChoiceList

    public function getChoicesForValues(array $values)
    {
        if (empty($values) || empty($first = reset($values))) {
            return array();
        }

The text was updated successfully, but these errors were encountered:

Tobion · 2015-05-08T00:28:44Z

Fixed in #14465 I guess.

piogrek · 2015-05-08T07:07:40Z

It was fixed partially. but in our case exception happens in ModelChoiceList , before the null/empty check in ChoiceToValueTransformer.

still not fixed, but I can't re-open this ticket now

mbartok · 2015-05-10T12:17:02Z

Same error after submitting optional entity form field type with empty_value with doctrine on Symfony 2.7 (e60f715). Related issues are #14393 and #14465, but non of those fixes seems to fix this issue.

Field definition:

$builder->add('dealer', 'entity', array(
    'label' => 'useraccount.label.dealer',
    'class' => 'MyAppBundle:Subject',
    'choice_label' => 'label',
    'empty_value' => '',
    'multiple' => false,
    'required' => false
));

After submitting empty value i get this error:

SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: ""

It seems like Symfony is trying to find Subject entity using empty string as id for dealer field:

DBALException: An exception occurred while executing 'SELECT ... FROM subject s0_ WHERE s0_.id IN (?)' with params [""]:

piogrek · 2015-05-10T12:29:09Z

Seems to be the same problem, but fix needs to be done either in ChoiceToValueTransformer (for both model and entity lists) or separately in bridge ChoiceList classes

| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#14583 | License | MIT | Doc PR | Fixes symfony#14583.

madmis · 2015-05-29T20:25:05Z

+1
ChoiceToValueTransformer
Form

$builder->add('country', 'entity', [
            'class' => 'AppBundle\Entity\Country',
            'query_builder' => function (EntityRepository $er) {
                return $er->createQueryBuilder('c')
                    ->orderBy('c.name', 'ASC');
            },
        ]);

If in this case i try save empty value, i have error

An exception occurred while executing 'SELECT c0_.id AS id0, c0_.iso_code AS iso_code1, c0_.name AS name2, c0_.slug AS slug3 FROM country c0_ WHERE c0_.id IN (?) ORDER BY c0_.name ASC' with params [""]:

SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: ""

If set 'empty_data' => 0,

$builder->add('country', 'entity', [
            'class' => 'AppBundle\Entity\Country',
            'empty_data' => 0,
            'query_builder' => function (EntityRepository $er) {
                return $er->createQueryBuilder('c')
                    ->orderBy('c.name', 'ASC');
            },
        ]);

worked without errors

Symfony version 2.7.0-DEV

tmeliberty · 2015-06-01T08:51:51Z

@madmis by trying this workaround I get an TransformationFailureException "The choice "0" does not exist or is not unique" and it break my form validation

Symfony 2.7.0 LTS

althaus · 2015-06-01T14:19:17Z

This happens for me with the placeholder option:

$builder->add('category', null, array(
            'label' => _('Category'),
            'order_by' => 'title',
            'placeholder' => _('none'),
        ));

webmozart · 2015-06-11T15:53:13Z

This bug is fixed for Doctrine in #14950.

althaus · 2015-06-12T07:34:29Z

That fix solves my issue... although it feels somehow hacky to just filter any non-integers from the values. Shouldn't it be fixed somehow related to empty_data as this is the cause of the empty string?

…by int ID (webmozart) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fixed: Filter non-integers when selecting entities by int ID | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14583 (for Doctrine, not Propel) | License | MIT | Doc PR | - This PR fixes #14583 for Doctrine. Non-integer values (like `""`) are not passed to the database anymore when selecting entities by integer PK, which causes an error on some DBMSs (like PostgreSQL). Commits ------- 352be8e [Form] Fixed: Filter non-integers when selecting entities by int ID

symfony/symfony#14583

garak · 2016-02-03T14:21:43Z

I just found this issue since I'm getting exactly this problem, but with guid type. I think that guid should be added to the array of types to check.
So, instead of array('integer', 'bigint', 'smallint'), it should be array('integer', 'bigint', 'smallint', 'guid')

See symfony#14583 (comment)

This PR was squashed before being merged into the 2.3 branch (closes #17668). Discussion ---------- add 'guid' to list of exception to filter out | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14583 | License | MIT | Doc PR | none See #14583 (comment) Commits ------- 0de86ff add 'guid' to list of exception to filter out

Tobion closed this as completed May 8, 2015

Tobion reopened this May 8, 2015

xabbuh mentioned this issue May 10, 2015

[Form] Fixed regression: Empty values were not accepted anymore for collapsed, optional choice fields #14465

Merged

jakzal added the Form label May 12, 2015

phansys mentioned this issue May 12, 2015

[2.7] [WIP] Fix for #14583 #14617

Closed

1 task

phansys mentioned this issue Jun 5, 2015

Field of type entity does not support null value #14856

Closed

nicolas-grekas added the BC Break label Jun 5, 2015

webmozart mentioned this issue Jun 11, 2015

[Form] Fixed: Filter non-integers when selecting entities by int ID #14950

Merged

webmozart mentioned this issue Jun 11, 2015

[2.7][Form] #14465 introduced a new regression: empty required choice fields are not validated anymore #14607

Closed

fabpot closed this as completed Jun 12, 2015

nobuhiko added a commit to nobuhiko/ec-cube that referenced this issue Jun 22, 2015

symfonyのバグ？

22ff0c3

symfony/symfony#14583

mcrawford-dayspring mentioned this issue Nov 5, 2015

Error when submitting empty value for optional choice field in Propel #16478

Closed

garak added a commit to garak/symfony that referenced this issue Feb 3, 2016

add 'guid' to list of exception to filter out

0b8edcb

See symfony#14583 (comment)

garak mentioned this issue Feb 3, 2016

add 'guid' to list of exception to filter out #17668

Closed

maryo mentioned this issue Aug 6, 2017

Entity form type fails when submiting an empty value for non-string identifier type on Postgres #23808

Closed

Devristo mentioned this issue Jan 2, 2020

[Doctrine bridge] Support custom ID-types in EntityType / ORMQueryBuilderLoader #35165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[form] error when submitting empty value in for using model choice list #14583

[form] error when submitting empty value in for using model choice list #14583

piogrek commented May 7, 2015

Tobion commented May 8, 2015

piogrek commented May 8, 2015

mbartok commented May 10, 2015

piogrek commented May 10, 2015

madmis commented May 29, 2015

tmeliberty commented Jun 1, 2015

althaus commented Jun 1, 2015

webmozart commented Jun 11, 2015

althaus commented Jun 12, 2015

garak commented Feb 3, 2016

[form] error when submitting empty value in for using model choice list #14583

[form] error when submitting empty value in for using model choice list #14583

Comments

piogrek commented May 7, 2015

Tobion commented May 8, 2015

piogrek commented May 8, 2015

mbartok commented May 10, 2015

piogrek commented May 10, 2015

madmis commented May 29, 2015

tmeliberty commented Jun 1, 2015

althaus commented Jun 1, 2015

webmozart commented Jun 11, 2015

althaus commented Jun 12, 2015

garak commented Feb 3, 2016