Skip to content

[BrowserKit] odd handling of HTTP_HOST header in Client::request #15398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Naktibalda opened this issue Jul 28, 2015 · 0 comments
Closed

[BrowserKit] odd handling of HTTP_HOST header in Client::request #15398

Naktibalda opened this issue Jul 28, 2015 · 0 comments
Labels
BrowserKit

Comments

@Naktibalda
Copy link
Contributor

  1. If HTTP_HOST is set in $server parameter of request method, it overrides hostname part of URI.
    https://github.com/symfony/BrowserKit/blob/292751e7b351b1e7d400c7529c07d713af2ff92a/Client.php#L299
  2. HTTP_HOST header is set to hostname part of URI.
    https://github.com/symfony/BrowserKit/blob/292751e7b351b1e7d400c7529c07d713af2ff92a/Client.php#L313
  3. HTTP_HOST set with setServerParameters is completely ignored.

The first action is completely unexpected and should be removed.
The second action should only be used if HTTP_HOST is not set in $server.
Currently it is set to localhost by default
which is never used, so it should be removed.
Naktibalda added a commit to Naktibalda/symfony that referenced this issue Jul 29, 2015
@Naktibalda
Corrected HTTP_HOST logic symfony#15398
47a6d64
Naktibalda added a commit to Naktibalda/symfony that referenced this issue Jul 29, 2015
@Naktibalda
[BrowserKit] Corrected HTTP_HOST logic symfony#15398
dbea000
@Naktibalda Naktibalda mentioned this issue Jul 29, 2015
Closed
Naktibalda added a commit to Naktibalda/symfony that referenced this issue Aug 1, 2015
@Naktibalda
[BrowserKit] Corrected HTTP_HOST logic symfony#15398
d20878e
Naktibalda added a commit to Naktibalda/symfony that referenced this issue Aug 1, 2015
@Naktibalda
[BrowserKit] Corrected HTTP_HOST logic symfony#15398
b869e4b
@Naktibalda Naktibalda mentioned this issue Aug 1, 2015
Closed
Naktibalda added a commit to Naktibalda/symfony that referenced this issue Oct 16, 2015
@Naktibalda
[BrowserKit] Corrected HTTP_HOST logic symfony#15398
d498adc
@Naktibalda Naktibalda mentioned this issue Oct 16, 2015
Closed
fabpot pushed a commit that referenced this issue Jan 27, 2016
@Naktibalda @fabpot
[BrowserKit] Corrected HTTP_HOST logic #15398
b5f524d
fabpot added a commit that referenced this issue Jan 27, 2016
@fabpot
bug #16265 [BrowserKit] Corrected HTTP_HOST logic (Naktibalda)
7365bc0 
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #16265).

Discussion
----------

[BrowserKit] Corrected HTTP_HOST logic

HTTP_HOST is just a header - it does not override URI,
uri does not override HTTP_HOST header.
If HTTP_HOST is not set then and only then hostname is extracted from uri.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15398
| License       | MIT
| Doc PR        |

Commits
-------

b5f524d [BrowserKit] Corrected HTTP_HOST logic #15398
@fabpot fabpot closed this as completed Jan 27, 2016
xabbuh added a commit that referenced this issue Jan 27, 2016
@xabbuh
Merge branch '2.3' into 2.7
3a027ba 
* 2.3:
  fixed CS
  [BrowserKit] Corrected HTTP_HOST logic #15398
  resolve aliases in factory services
  Remove invalid CSS white-space value
  Fix FileSystem tests on Windows
xabbuh added a commit that referenced this issue Jan 27, 2016
@xabbuh
Merge branch '2.7' into 2.8
c8d28b1 
* 2.7:
  fixed CS
  [BrowserKit] Corrected HTTP_HOST logic #15398
  resolve aliases in factories
  resolve aliases in factory services
  Remove invalid CSS white-space value
  Fix FileSystem tests on Windows
  [Form] ArrayChoiceList can now deal with a null in choices
xabbuh added a commit that referenced this issue Jan 27, 2016
@xabbuh
Merge branch '2.8' into 3.0
f204104 
* 2.8:
  fixed CS
  [BrowserKit] Corrected HTTP_HOST logic #15398
  Fixed HTTP Digest auth not being passed user checker
  resolve aliases in factories
  resolve aliases in factory services
  Remove invalid CSS white-space value
  Fix FileSystem tests on Windows
  [Form] ArrayChoiceList can now deal with a null in choices
@tomchkk tomchkk mentioned this issue Apr 1, 2016
Closed
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@xabbuh
Merge branch '2.3' into 2.7
ae364ba 
* 2.3:
  fixed CS
  [BrowserKit] Corrected HTTP_HOST logic symfony#15398
  resolve aliases in factory services
  Remove invalid CSS white-space value
  Fix FileSystem tests on Windows
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@xabbuh
Merge branch '2.7' into 2.8
aef1089 
* 2.7:
  fixed CS
  [BrowserKit] Corrected HTTP_HOST logic symfony#15398
  resolve aliases in factories
  resolve aliases in factory services
  Remove invalid CSS white-space value
  Fix FileSystem tests on Windows
  [Form] ArrayChoiceList can now deal with a null in choices
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@xabbuh
Merge branch '2.8' into 3.0
c9997bc 
* 2.8:
  fixed CS
  [BrowserKit] Corrected HTTP_HOST logic symfony#15398
  Fixed HTTP Digest auth not being passed user checker
  resolve aliases in factories
  resolve aliases in factory services
  Remove invalid CSS white-space value
  Fix FileSystem tests on Windows
  [Form] ArrayChoiceList can now deal with a null in choices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BrowserKit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @Naktibalda @xabbuh