@schmittjoh Say you use JMSSecurityExtraBundle. This requires having 2 methods when you don't have a ParamConverter: the action getting the id, and another action called after converting the param as JMSSecurityExtraBundle needs to have the object.

@schmittjoh I dont use annotations at all, if i use parameter converters for "viewAction(Object $obj)" then i could directly check if all grants are valid and throw a 403 exception otherwise. This would be reusable across all controllers that trigger this parameter converter.

Edit: Not sure if this is the right place though, i would need to try it in a real world app to see if there are downsides.

@beberlei if i read this correctly is the exact same way the work currently, you dont need the annotation i will also take every typehint into considoration. I have this for injecting the current user into my controller actions and other nifty things :)

Also if this is moved back (again) the request injection magic should be moved to a param converter.

I have some questions about the implementation of FrameworkExtraBundle:

Why doesn't it allow to override a parameter, i.e. transform a request variable "{from}" into a \DateTime $from. The ParamConverterManager disalllows this. Is there any reason for this?

Edit: I think the ParamConverterManager is sufficently protecting overwriting variables multiple times or in the wrong semantics.

How does the ParamConverterManager disallow this? the only thing you need is to Typecast the $from variable in you action definition.

<?php
// ...
public function myAction(\DateTime $from) {
    // ... some more stuff
}

Then if there is a ParamConverter that matches then it would be called.

See ParamConverterManager if ($request->attributes->has()) condition which calls unset($configuration[$key]);

Dosent it only continue because the highest supported converter have converted the request variable? cant see a unset in the code.

@fabpot any thoughts about it ?

This is too late for 2.1, i don't mache too much time the next months sadly, so I can't bring this forward. Plus I have some ideas about Param Converters that should probably be tested in Sensio Extra first.

OK, let's re-schedule the discussion for 2.2

We could make it a Component maybe?

@henrikbjorn maybe, but it is too late to have it for 2.1 IMO (especially if we want to improve the design of the param converters as the current implementation has some limitations)

What are the current limitations? Especially if we drop Annotation support i cant really see any.

@henrikbjorn the fact that the current converter does not support being used for several params of the route (unless a fix has finally been merged for this)

@stof that was fixed some time ago. It dosent support multiple annotations but the behavior described by Benjamin is supported. See https://github.com/sensio/SensioFrameworkExtraBundle/blob/master/EventListener/ParamConverterListener.php#L64

I'd be interested in implementing this in HttpKernel without annotation support (IMO that should remain for the FrameworkExtraBundle). Main reason is, that I frequently use components standalone and param converter would be something handy to have.

Would this be generally accepted? (if the code is up to par of course)

This issue should probably be closed because the feature requested by @beberlei is already included in Symfony.

@javiereguiluz to be exact, the feature is in FrameworkExtraBundle, not in Symfony. @beberlei was asking to move it in core

@stof I'm glad to read this, because that means that solving this issue will be truly easy. We just need the Symfony core to make a yes/no decision.

@javiereguiluz I'm in favor of doing this move, but it's not as easy as it sounds.

I expressed myself really bad. What I though it should be easy is to take a decision, not solving the issue. And reading you comment, the decision is clearly: yes.

Please note that I've started working on this issue: #11457

Sadly, it can't be done without BC breaks.

@wouterj didnt see you already started working on this

tried to extract it from the FrameworkExtraBundle https://github.com/henrikbjorn/ParamConverter but i am all for refactoring and rethinking the approach.

What state is this in? It looks like there was some voting proposal but just initiator voted.

@henrikbjorn Good job for extracting the feature!