Skip to content

[Form] Exception handling in DateTimeToStringTransformer should be simplified #16237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MisatoTremor opened this issue Oct 14, 2015 · 0 comments
Closed

[Form] Exception handling in DateTimeToStringTransformer should be simplified #16237

MisatoTremor opened this issue Oct 14, 2015 · 0 comments

Comments

@MisatoTremor
Copy link
Contributor

As discussed with @stof in #15030 there is an unneeded catch and re-throw in the reverseTransform function.
@MisatoTremor MisatoTremor mentioned this issue Oct 14, 2015
Closed
fabpot added a commit that referenced this issue Oct 19, 2015
@fabpot
minor #16238 [Form] Remove unneeded catch and re-throw in DateTimeToS…
66c99a0 
…tringTransformer (MisatoTremor)

This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #16238).

Discussion
----------

[Form] Remove unneeded catch and re-throw in DateTimeToStringTransformer

| Q             | A
| ------------- | ---
| Fixed tickets | #16237
| License       | MIT

Also fixed PHPDoc param for ``transform``.

Commits
-------

2c9b283 [Form] Simplify DateTimeToStringTransformer Avoid unneeded catch and re-throw of the same exception.
@fabpot fabpot closed this as completed Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @MisatoTremor