Skip to content

[Form][2.8,3.0] Type guesser guesses alias instead of FQCN #16332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hiddewie opened this issue Oct 24, 2015 · 2 comments
Closed

[Form][2.8,3.0] Type guesser guesses alias instead of FQCN #16332

hiddewie opened this issue Oct 24, 2015 · 2 comments
Labels
Form

Comments

@hiddewie
Copy link
Contributor

In the file Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php of branch 2.8 (and master), the quessed form types are the old aliases. They should be updated to quess the FQDN of the form type, as decided and implemented in #15079.
@Tobion
Copy link
Contributor

Tobion commented Oct 24, 2015

Yeah I also saw that when working on #16302

@hiddewie hiddewie mentioned this issue Oct 24, 2015
Closed
@hiddewie
Copy link
Contributor Author

After my PR has been merged and 2.8 has been merged into master, I'll create a new pull request with the same edits using the ::class constant.

@xabbuh xabbuh added the Form label Oct 25, 2015
Tobion added a commit that referenced this issue Oct 26, 2015
@Tobion
bug #16334 Updated type guessers to use FQCNs for guessed types (hidd…
2419000 
…ewie)

This PR was squashed before being merged into the 2.8 branch (closes #16334).

Discussion
----------

Updated type guessers to use FQCNs for guessed types

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16332
| License       | MIT
| Doc PR        | symfony/symfony-docs#5834 (if applicable)

Commits
-------

e871db7 Updated type guessers to use FQCNs for guessed types
@Tobion Tobion closed this as completed Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tobion @hiddewie @xabbuh