Skip to content

BC Break regression in ParameterBag #17058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
craigh opened this issue Dec 17, 2015 · 1 comment
Closed

BC Break regression in ParameterBag #17058

craigh opened this issue Dec 17, 2015 · 1 comment
Labels
HttpFoundation

Comments

@craigh
Copy link

craigh commented Dec 17, 2015

Here: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/HttpFoundation/ParameterBag.php#L271

The error type is set as E_USER_ERROR when it should be E_USER_DEPRECATED. using E_USER_ERROR throws non-recoverable exception and breaks the site whether env:prod or env:dev.

changing it to E_USER_DEPRECATED fixes problem for me.
@craigh craigh mentioned this issue Dec 17, 2015
Closed
@xabbuh xabbuh mentioned this issue Dec 17, 2015
Merged
@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2015

see #17059

stof added a commit that referenced this issue Dec 17, 2015
@stof
bug #17059 [HttpFoundation] fix error level for deprecation (xabbuh)
2172054 
This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] fix error level for deprecation

| Q             | A
| ------------- | ---
| Fixed tickets | #17058
| License       | MIT

Commits
-------

4929634 fix error level for deprecation
@stof stof closed this as completed Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@craigh @stof @xabbuh