Skip to content

[DX][WebProfilerBundle] Add HTTP return code in the Ajax request list table #17518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PeterFour opened this issue Jan 25, 2016 · 5 comments
Closed
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) WebProfilerBundle

Comments

@PeterFour
Copy link

Hi,

It would be nice to have a new column to get the HTTP return code of the AJAX request.

Sometime the request list contain one failed request and instead of having to go into the profiler it would be easier to directly have the failing one and go to the profiler entry straight away.

@mickaelandrieu
Copy link
Contributor

Hi,
agree, or at least make the row background red when the return code is not valid (4xx, 5xx).

This make debugging ajax calls hard because you have to open each profiler links until you find the one you are looking for.

Regards,

@PeterFour
Copy link
Author

@mickaelandrieu Yes that would be a nice touch too (or an alternative to adding a new column), it could be done also for 3xx even if I don't really encounter those quite often in AJAX

@mickaelandrieu
Copy link
Contributor

@javiereguiluz do you agree ? I can make a pull request to add a new column 'HTTP Status code'.

@javiereguiluz javiereguiluz added WebProfilerBundle DX DX = Developer eXperience (anything that improves the experience of using Symfony) labels Jan 26, 2016
@Jean85
Copy link
Contributor

Jean85 commented Jan 26, 2016

@PeterFour 3xx in AJAX are treated transparently (as from W3C specification), so you NEVER see them: you directly see the destination page, with its HTTP response code.

kucharovic added a commit to kucharovic/symfony that referenced this issue Jan 26, 2016
Q | A
---|---
Bug fix? | no
New feature? | yes
BC breaks? | no
Deprecations? | no
Tests pass? | yes
Fixed tickets | [17518](symfony#17518)
License | MIT
Doc PR | -
kucharovic added a commit to kucharovic/symfony that referenced this issue Jan 26, 2016
Q | A
---|---
Bug fix? | no
New feature? | yes
BC breaks? | no
Deprecations? | no
Tests pass? | yes
Fixed tickets | symfony#17518
License | MIT
Doc PR | -
@PeterFour
Copy link
Author

@Jean85 My bad then :) That would explain why I never saw any in the profiler table

fabpot added a commit that referenced this issue Jan 27, 2016
…equest list table (kucharovic)

This PR was submitted for the 2.8 branch but it was merged into the 3.1-dev branch instead (closes #17540).

Discussion
----------

[WebProfilerBundle] Add HTTP return code in the Ajax request list table

Q | A
---|---
Bug fix? | no
New feature? | yes
BC breaks? | no
Deprecations? | no
Tests pass? | yes
Fixed tickets | #17518
License | MIT
Doc PR | -

Commits
-------

9192e1b [WebProfilerBundle] Add HTTP return code in the Ajax request list table
@fabpot fabpot closed this as completed Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) WebProfilerBundle
Projects
None yet
Development

No branches or pull requests

5 participants