Since Symfony 3.0.2, the twig->render method doesn't work with absolute path #17777

Congelli501 · 2016-02-12T12:22:41Z

Environment:

PHP 5.6
GNU/Linux
Symfony 3.0.2 (ok with 3.0.1)

Since Symfony 3.0.2, the Symfony\Component\Templating\EngineInterface::render method doesn't work with absolute path to the template file (Unable to find template error).

Step to reproduce (from sratch):

# Install a base sf project
wget https://symfony.com/installer
chmod +x installer
./installer new testp
cd testp/

# Use an absolute path to a twig template
cat > src/AppBundle/Controller/DefaultController.php << 'EOF'
<?php

namespace AppBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class DefaultController extends Controller
{
    /**
     * @Route("/", name="homepage")
     */
    public function indexAction(Request $request)
    {
        $absPath = $this->get('kernel')->getRootDir() . '/Resources/views/default/index.html.twig';

        // replace this example code with whatever you need
        return $this->render($absPath, [
            'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
        ]);
    }
}
EOF


# Test with symfony 3.0.2
php bin/console server:run

## Go to http://127.0.0.1:8000 --> Unable to find template "/.../testp/app/Resources/views/default/index.html.twig".

# Switch to symfony 3.0.1
patch -p0 --batch --forward composer.json << 'EOF'
--- composer.json.1 2016-02-12 12:57:16.729074815 +0100
+++ composer.json   2016-02-12 12:57:26.717103221 +0100
@@ -18,7 +18,7 @@
     },
     "require": {
         "php": ">=5.5.9",
-        "symfony/symfony": "3.0.*",
+        "symfony/symfony": "3.0.1",
         "doctrine/orm": "^2.5",
         "doctrine/doctrine-bundle": "^1.6",
         "doctrine/doctrine-cache-bundle": "^1.2",
EOF

composer update

# Test with symfony 3.0.1
## Go to http://127.0.0.1:8000 --> Ok

xabbuh · 2016-02-12T16:19:15Z

Looks like this is caused by #15272 (see #17683).

Status: Reviewed

ping @jakzal

jakzal · 2016-02-12T17:22:24Z

I started looking into this. My problem is there's no clear reference on what kind of paths should be supported by the TemplateNameParser from the FrameworkBundle. Some of the test cases in #15272 are inferred from the existing code (which might be wrong).

re #12894 (comment)

jakzal · 2016-02-15T08:22:09Z

I won't be able to look into this before the weekend.

wesleylancel · 2016-02-17T18:10:05Z

I'm seeing a regression where the latest 2.8.x-dev is no longer able to parse the following snippet, whereas 2.8.2 is. Possibly the same cause?

{% extends "@FOSUserBundle/Resources/views/layout.html.twig" %}

Edit: did some testing, can confirm that this was caused by the changes in #15272. The regular expression changed in that PR did not match @FOSUserBundle/Resources/views/layout.html.twig before, but does after, however, it can't properly parse it.

xabbuh · 2016-02-17T21:58:34Z

@wesleylancel What error exactly do you experience?

wesleylancel · 2016-02-17T22:06:08Z

@xabbuh: I'll look up the exact error tomorrow but it says it can't the template in views/@FOSUserBundle or something. Before the PR it simply didn't parse it because the regexp didn't match and it was passed off to Twig, now it does but it can't actually get all the parts correctly so the TemplateReference contains incorrect data.

francoispluchino · 2016-02-18T08:29:53Z

@wesleylancel The list of affected versions of Symfony is listed in #17683.

jakzal · 2016-02-22T18:08:14Z

I'm looking into fixing this now. @wesleylancel I'd appreciate if you shared the stack trace

…mplate paths (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Fix a regression in handling absolute template paths | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17777 #17683 | License | MIT | Doc PR | - Regression introduced by #15272. Commits ------- d8c493f [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths

francoispluchino · 2016-03-03T16:30:41Z

@jakzal, @fabpot You close this issue while the PR #17894 is not merged into the 3.0.x branch (and ^2.3). Is it not better to keep this issue open until all the branches be merged?

jakzal · 2016-03-03T17:29:16Z

@francoispluchino in our workflow issues are closed as soon as a related PR is merged. There's no need to keep them open. Older branches are merged into newer ones on a regular basis.

francoispluchino · 2016-03-03T17:31:36Z

@jakzal Ok, thank you for the precisions!

Babacooll · 2016-03-16T17:05:00Z

@xabbuh @jakzal I'm sorry to bother you with this, has this been fixed in Symfony 2.8 ? I've seen a release for Symfony 2.3 but not higher. Thanks !

jakzal · 2016-03-16T17:07:57Z

Indeed, only Symfony 2.3 was released recently. Don't worry though, 2.7-3.0 will be released soon and will include this fix.

javiereguiluz added Bug Templating Unconfirmed labels Feb 12, 2016

carsonbot added the Status: Needs Review label Feb 12, 2016

xabbuh added the BC Break label Feb 12, 2016

carsonbot added Status: Reviewed and removed Status: Needs Review labels Feb 12, 2016

xabbuh mentioned this issue Feb 12, 2016

[3.0.2][BUG][Templating] Regression introduced in TemplateNameParser #17683

Closed

javiereguiluz removed the Unconfirmed label Feb 14, 2016

jakzal mentioned this issue Feb 22, 2016

[FrameworkBundle] Fix a regression in handling absolute template paths #17894

Merged

Jean85 mentioned this issue Mar 1, 2016

View location bug with Symfony 2.8.3 #17969

Closed

fabpot closed this as completed Mar 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Since Symfony 3.0.2, the twig->render method doesn't work with absolute path #17777

Since Symfony 3.0.2, the twig->render method doesn't work with absolute path #17777

Congelli501 commented Feb 12, 2016

xabbuh commented Feb 12, 2016

jakzal commented Feb 12, 2016

jakzal commented Feb 15, 2016

wesleylancel commented Feb 17, 2016

xabbuh commented Feb 17, 2016

wesleylancel commented Feb 17, 2016

francoispluchino commented Feb 18, 2016

jakzal commented Feb 22, 2016

francoispluchino commented Mar 3, 2016

jakzal commented Mar 3, 2016

francoispluchino commented Mar 3, 2016

Babacooll commented Mar 16, 2016

jakzal commented Mar 16, 2016

Since Symfony 3.0.2, the twig->render method doesn't work with absolute path #17777

Since Symfony 3.0.2, the twig->render method doesn't work with absolute path #17777

Comments

Congelli501 commented Feb 12, 2016

xabbuh commented Feb 12, 2016

jakzal commented Feb 12, 2016

jakzal commented Feb 15, 2016

wesleylancel commented Feb 17, 2016

xabbuh commented Feb 17, 2016

wesleylancel commented Feb 17, 2016

francoispluchino commented Feb 18, 2016

jakzal commented Feb 22, 2016

francoispluchino commented Mar 3, 2016

jakzal commented Mar 3, 2016

francoispluchino commented Mar 3, 2016

Babacooll commented Mar 16, 2016

jakzal commented Mar 16, 2016