Skip to content

[WebProfiler] Sidebar hover bug on small window #18405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
norkunas opened this issue Apr 1, 2016 · 4 comments
Closed

[WebProfiler] Sidebar hover bug on small window #18405

norkunas opened this issue Apr 1, 2016 · 4 comments

Comments

@norkunas
Copy link
Contributor

norkunas commented Apr 1, 2016

Browser Chrome 49.0.2623.110
OS Windows
SF 2.8

image

@javiereguiluz
Copy link
Member

I can't reproduce it:

webprofiler_responsive

The sidebar menu should collapse automatically on small screens. This feature was implemented by @hason in #15818.

@norkunas
Copy link
Contributor Author

norkunas commented Apr 1, 2016

@javiereguiluz you didn't hover on sidebar

@norkunas
Copy link
Contributor Author

norkunas commented Apr 1, 2016

Also looking at your gif my eye caught this
image
So if you hover on the sidebar i think you'll see what i see

@javiereguiluz
Copy link
Member

@norkunas I'm sorry. You are right. This should be fixed in #18407.

fabpot added a commit that referenced this issue Apr 1, 2016
…ereguiluz)

This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #18407).

Discussion
----------

Fixed the "hover" state of the profiler sidebar menu

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18405
| License       | MIT
| Doc PR        | -

### Before

![before_sidebar](https://cloud.githubusercontent.com/assets/73419/14209368/2cc6e168-f824-11e5-91e7-70fab8d64d12.gif)

### After

![after_sidebar](https://cloud.githubusercontent.com/assets/73419/14209376/3295d7a2-f824-11e5-94b5-254f1fc4e027.gif)

Commits
-------

85deb30 Fixed the "hover" state of the profiler sidebar menu
@fabpot fabpot closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants