Can you post a code snippet to reproduce the problem?

No need. Just use symfony-standard master.

P.S. It seems that this one is also PHP 7.1 specific

I can't reproduce this on PHP 7.1.0-beta2 on Windows.

Status: works for me

I have beta3. Unfortunately I cannot run it through debugger as the upcoming xdebug 2.5 segfaults for me.

status: reviewed

I can reproduce this with PHP 7.1-beta3. However, this is probably a bug in PHP, as it's working as expected in all PHP versions except 7.1-beta3?

It might be. I have no crash if I switch back to 7.0. However symfony might do something that's not allowed anymore.

The problem is that in PHP 7.1-beta3, ReflectionParameter::getType() is returning a FQCN (with leading \), while we're === comparing it with Request::class, which does not include the leading \.

Reported the bug at PHP, to see if this can be reverted or at least more explicitely documented: https://bugs.php.net/bug.php?id=72906

The API Platform test suite also fails for other reasons with the latest 7.1 (it was green before the beta 3). PHP even segfault. The last beta looks buggy, I think we should only allow failure for 7.1 until it becomes more stable.

Take a look at the last comment from @nikic in php/php-src#2068 The BC seems to be intentional to support nullable types.

The feature will be reverted in PHP: https://bugs.php.net/bug.php?id=72906#1471710916

For now, please downgrade your PHP version to PHP 7.1.0-beta2 or PHP 7.0.9. This issue can be closed.

while we're === comparing it with Request::class, which does not include the leading

I'm going to take just this one out of the context as it probably should be solved in 3.2. The new nullable types would probably need to be supported in argumetresolver and through the framework as I imagine a lot of ppl will now use them. That's the main reason I'm even running the betas.

This class should probably receive a compatibility update for the nullable: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadataFactory.php

My guess is that it should give a default value with null, meaning hasDefaultValue() should do more than checking just return $parameter->isDefaultValueAvailable();. However, I expect PHP to keep this backwards compatible in 7.1.

@iltar thing is, ReflectionType#__toString() will prefix the FQCN with ? when the class is nullable. So the === check doesn't not make much sense anymore. I'm not sure if they are going to revert only the \ change, or also the ? change. If both are reverted, there is no work to do in Symfony. If only \ is reverted, support for ?Symfony\Component\HttpFoundation\Request should be added (e.g. rtrim($parameter->getType(), '?')).

This also applies to other places using ReflectionType#__toString().

I will try to find a 7.1-beta3 monday if I can so I can build a patch for it (please do remind me if you can)

This took unexpected turn. It seems that I wasn't clear enough. If they do revert the patch there is nothing to do from the symfony side, you are correct.
What I meant when I quoted the part of message is it would still be nice if symfony would support nullable types in 3.2 in "all" resolvers/container builder.... e.g. ?Foo $foo woudn't throw exception but null would be injected if necessary.

Everything has been reverted: php/php-src@8855a2c this can now be closed

@mvrhov can you open a new issue for that? I think this is something that has to be merged into 3.1 and 3.2.

As noted by @wouterj, I've reverted the changes so that ReflectionType::__toString() is now identical to 7.0, including not prepending a ? for nullable types. The method is now just an alias of ReflectionNamedType::getName().

ReflectionType::__toString() should be discouraged for code generation going forward, as it seems there's just not a way to add type features in a BC way. My attempt to incorporate nullable types in a way that would allow for even more complex types such as callable(?\Type\Name, ?bool) just caused too many problems. Instead of relying on __toString(), use the other ReflectionType methods and ReflectionNamedType::getName() to build syntax-valid code that supports nullable types.

@symfony/deciders this can be closed

Note that the revert commit has been reverted: php/php-src@f4e68a3

This should be reopened. And we should add tests for this.

@teohhanhui #19811 #19784

Only the ? nullable prefix is added back, the \ is still reverted (which was the bug reported in this issue)

PropertyInfo needs fixing too (ReflectionExtractor). Is there already a PR for that?

@teohhanhui PropertyInfo doesn't need a fix. It is already compatible with 7.1 because it uses ReflectionParameter::allowsNull: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php#L164-L166

@teohhanhui but it indeed needs an update for the return type.

@dunglas Please take a look at #19853