Skip to content

Symfony 3.2-RC1 errors in the Symfony Profiler #20556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Nov 18, 2016 · 5 comments
Closed

Symfony 3.2-RC1 errors in the Symfony Profiler #20556

javiereguiluz opened this issue Nov 18, 2016 · 5 comments
Labels
Bug Critical Status: Reviewed WebProfilerBundle
Milestone
3.2

Comments

@javiereguiluz
Copy link
Member

In symfony/demo#403 I've just updated the Symfony Demo app to Symfony 3.2-RC1 and Twig 1.28. I have a lot of issues in the Symfony profiler:

  1. The few profiler panels that work right mess up the entire sidebar menu:

error_1

error_2

  1. Most of the profiler panels don't work and display a lot of errors:

error_3

error_4

error_5
@javiereguiluz
Copy link
Member Author

I've just upgraded an internal Symfony app to 3.2-rc1 and I'm getting the same errors.

@Cydonia7
Copy link
Contributor

Status: Reviewed

I reproduced the bug on symfony demo upgrading symfony/symfony to dev-master. Thanks @javiereguiluz for reporting such an important issue.

@xabbuh xabbuh added this to the 3.2 milestone Nov 18, 2016
@martinbertinat martinbertinat mentioned this issue Nov 18, 2016
Closed
@derrabus
Copy link
Member

derrabus commented Nov 18, 2016 •
edited
Loading

I can reproduce this on the 2.7 branch as well. This commit by @fabpot seems to be the one that breaks everything: b8f7614 (PR #20484)

If I simply revert that commit on 2.7, everything's fine again.

@derrabus derrabus mentioned this issue Nov 18, 2016
Merged
@derrabus
Copy link
Member

I have created PR twigphp/Twig#2269 that fixes this issue. But maybe we should revert the commit I've mentioned above until the issue is fixed in Twig.

@stof
Copy link
Member

stof commented Nov 18, 2016

I don't think we need reverting this, as Symfony 2.7 does not have an impacted release yet. We just need to release Twig 1.28.1 before the next Symfony 2.7 patch release (which is under our control as @fabpot is doing releases on both sides)

@stof stof removed the BC Break label Nov 18, 2016
fabpot added a commit to twigphp/Twig that referenced this issue Nov 19, 2016
@fabpot
bug #2269 Bugfix: When rendering blocks of other templates, don't pas…
f59b33a 
…s the local blocks array (derrabus, fabpot)

This PR was merged into the 1.x branch.

Discussion
----------

Bugfix: When rendering blocks of other templates, don't pass the local blocks array

This PR fixes symfony/symfony#20556.

When referring to a block of another template from within a template that also has a block with the same name, Twig renders the wrong block.

Commits
-------

8c090a7 added tests for block() when using a template argument
a5526f3 fixed block() is defined call when using a template argument
c04d077 Bugfix: When rendering blocks of other templates, don't pass the local blocks array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Critical Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
6 participants
@javiereguiluz @stof @derrabus @xabbuh @Cydonia7 @carsonbot