Upgraded the application to Symfony 3.2-RC1 and Twig 1.28 #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "twig/extensions" : "^1.3", | ||
| "twig/twig" : "^1.27", |
There was a problem hiding this comment.
Do we really need to bump Twig version in composer.json? I mean, do we really have strict dependency with Twig v1.28? it would be enough composer up twig/twig - Composer will install 1.28 and freeze it in composer.lock anyway since we have ^ in composer.json.
There was a problem hiding this comment.
Yes and no. As you can see in the CHANGELOG of 3.2-rc1:
bug #20484 bumped min version of Twig to 1.28 (@fabpot)
When some minimum version (e.g. 1.28) is mandatory for some dependency (e.g. Twig) I like to set it explicitly.
There was a problem hiding this comment.
Good to know, thanks for the explanation!
|
Superseded by #405 |
|
Closing it in favor of #405. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.