[YAML] Yaml::parse() does not handle empty lines in mulitline sequence elements #21005

W0rma · 2016-12-21T06:37:14Z

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	yes
Symfony version	2.8.15

The Yaml::parse() seems to have problems if an element of a sequence contains a multiline string containg an empty line:

$raw = <<<YAML
---
foo:
  bar:
  - field1: value
    field2: |
      bla

      bla
      bla
YAML;

try {
    \Symfony\Component\Yaml\Yaml::parse($raw);
} catch (\Symfony\Component\Yaml\Exception\ParseException $e) {
    // Exception is thrown
    $e->getMessage();
}

This example results in a ParseException with the message Unable to parse at line 8 (near " bla")..

If empty lines are used outside the sequence, Yaml::parse() does not throw the Exception. F.e. this example works fine:

    $raw = <<<YAML
---
foo:
  bar:
  - field1: value
    field2: |
      bla
      bla
      bla
  bar2: |
      bla

      bla
      bla
YAML;

\Symfony\Component\Yaml\Yaml::parse($raw);

try {
    \Symfony\Component\Yaml\Yaml::parse($raw);
} catch (\Symfony\Component\Yaml\Exception\ParseException $e) {
    // Exception is thrown
    $e->getMessage();
}

The text was updated successfully, but these errors were encountered:

stof · 2016-12-21T09:46:05Z

there is a difference between your 2 cases: in the second case, the line is not empty, but contains the indentation whitespaces like the bla lines. This may be why it works.

W0rma · 2016-12-21T11:51:47Z

I've updated my post. Case 2 works even if the line is empty

xabbuh · 2016-12-28T18:57:17Z

@W0rma Can you confirm that #21084 fixes your issue?

…bbuh) This PR was merged into the 2.7 branch. Discussion ---------- [Yaml] handle empty lines inside unindented collection | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21005 | License | MIT | Doc PR | Commits ------- bbfe6f7 handle empty lines inside unindented collection

W0rma · 2017-01-09T15:04:56Z

@xabbuh Yes, issue is fixed. Thank you!

W0rma changed the title ~~[YAML]~~ [YAML] Yaml::parse() does not handle empty lines in mulitline sequence elements Dec 21, 2016

javiereguiluz added Bug Unconfirmed Yaml labels Dec 21, 2016

carsonbot added the Status: Needs Review label Dec 21, 2016

xabbuh mentioned this issue Dec 28, 2016

[Yaml] handle empty lines inside unindented collection #21084

Merged

xabbuh added Status: Reviewed and removed Status: Needs Review Unconfirmed labels Dec 28, 2016

fabpot closed this as completed Jan 3, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[YAML] Yaml::parse() does not handle empty lines in mulitline sequence elements #21005

[YAML] Yaml::parse() does not handle empty lines in mulitline sequence elements #21005

W0rma commented Dec 21, 2016 •

edited

Loading

stof commented Dec 21, 2016

W0rma commented Dec 21, 2016

xabbuh commented Dec 28, 2016

W0rma commented Jan 9, 2017

[YAML] Yaml::parse() does not handle empty lines in mulitline sequence elements #21005

[YAML] Yaml::parse() does not handle empty lines in mulitline sequence elements #21005

Comments

W0rma commented Dec 21, 2016 • edited Loading

stof commented Dec 21, 2016

W0rma commented Dec 21, 2016

xabbuh commented Dec 28, 2016

W0rma commented Jan 9, 2017

W0rma commented Dec 21, 2016 •

edited

Loading