Rename DebugAccessDecisionManager to TraceableAccessDecisionManager #21085
Labels
Good first issue
Ideal for your first contribution! (some Symfony experience may be required)
Security
Comments
|
I would like to work on this! [EDIT] I'm working on my PR, and it's failing under PHP 7.x... it's normal since the subtree split is not updated or there's something else wrong? |
Jean85
added a commit
to Jean85/symfony
that referenced
this issue
Dec 29, 2016
|
The PR seems OK, and also 2 core member commented and approved there. Should we wait for further discussion? |
nicolas-grekas
added a commit
that referenced
this issue
Jan 3, 2017
…sionManager (Jean85) This PR was squashed before being merged into the 3.3-dev branch (closes #21088). Discussion ---------- Rename DebugAccessDecisionManager to TraceableAccessDecisionManager | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21085 | License | MIT [EDIT] No longer WIP, test passing. Also, test added to preserve BC with the SecurityBundle. Commits ------- c5e0e59 Rename DebugAccessDecisionManager to TraceableAccessDecisionManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A while ago we introduced
DebugAccessDecisionManagerto collect this information and display it in the Security panel of the Symfony Profiler. I though thatDebug + ...was a better name thanTraceable + .... However, every comparable class in Symfony is calledTraceable + ..., so we should renameDebugAccessDecisionManagertoTraceableAccessDecisionManager.This issue is an "easy pick", so it can be solved by any developer wanting to make their first contribution to Symfony. But first, let's wait and see if the Symfony Core members agree with this proposal.
The text was updated successfully, but these errors were encountered: