-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DI] Deprecate case insentivity of service identifiers #21193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree |
So the recommended way of getting service by name will from 4.00 be P.S. also service names will be longer I'm wondering how much more RAM will the cached DIC require and also if those strings go into the interned string cache the cache might become to small the default which is 4M might be to small even today |
@mvrhov we don't enforce using class names as id (it would break many use cases, as being able to replace an implementation is a great use case). |
Then the above doesn't make much sense (ok, it does, if the service name is class name). AFAIR the we switched once before to CI ones. |
I don't understand your answer |
… (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Deprecate case insentivity of service identifiers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | minor (see UPGRADE note) | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #21193 | License | MIT | Doc PR | - As discussed in linked RFC. Commits ------- d08f110 [DI] Deprecate case insentivity of service identifiers
Would doing the same for parameters be relevant? |
@chalasr I don't think so. I mean, deprecating for ids has first technical reason, which is doing more inlining, thus perf. For params, unless you can envision one, there is no such gain. |
Case insensitivity blocks some optimizations in the dumped container, slows down getting some services (especially now that we're going to use class names as ids) and adds code complexity.
We'd better make them case sensitive in 4.0, thus deprecate before.
The text was updated successfully, but these errors were encountered: