Skip to content

[Forms] NumberType value not updating #21734

Closed
@jonny-no1

Description

@jonny-no1
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.2.4

I noticed that when trying to change a NumberType's value from 37.36 to 37.37, it wouldn't update. I've created unit tests that reproduce the issue. The issue doesn't occur when setting an empty field's value to 37.37.

Assertion fails at: https://github.com/foaly-nr1/symfony/blob/153041ab7604b36ac33e2ef13d490edda739e994/src/Symfony/Component/Form/Tests/Extension/Core/Type/NumberTypeTest.php#L80

$ phpunit --filter=NumberTypeTest -v
Clock-mocked namespaces for SymfonyTestsListener need to be nested in a "time-sensitive" key. This will be enforced in Symfony 4.0.
PHPUnit 5.6.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.0.15 with Xdebug 2.5.0
Configuration: /Users/jonnyschmid/Sites/symfony/phpunit.xml.dist

Testing Symfony Test Suite
.....F                                                              6 / 6 (100%)

Time: 7.91 seconds, Memory: 130.00MB

There was 1 failure:

1) Symfony\Component\Form\Tests\Extension\Core\Type\NumberTypeTest::test3736to3737
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-37,37
+37,36

/Users/jonnyschmid/Sites/symfony/src/Symfony/Component/Form/Tests/Extension/Core/Type/NumberTypeTest.php:80

FAILURES!
Tests: 6, Assertions: 6, Failures: 1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions