Skip to content

Breaking Change introduced in Symonfy Filesystem #22328

Closed
@loilo

Description

@loilo
Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.2.7

Commit d50ffa1 introduced a breaking change to Filesystem's makePathRelative method.

Previously, running

$fs->makePathRelative('a', 'b');

correctly resulted in ../a/.

After the mentioned commit, running the same code now results in ./, which is clearly not correct.

This case is not covered by the Filesystem tests since they seem to only test absolute paths.

Imho there should either be tests for relative paths or it should be mentioned in the documentation that the makePathRelative method is only for absolute paths (which I don't assume).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions