Skip to content

[FrameworkBundle] assets:install does not clean unnecessary bundle folders #23177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Jun 14, 2017 · 2 comments
Closed

[FrameworkBundle] assets:install does not clean unnecessary bundle folders #23177

stof opened this issue Jun 14, 2017 · 2 comments
Labels
Bug Good first issue Ideal for your first contribution! (some Symfony experience may be required) Status: Needs Review

Comments

@stof
Copy link
Member

stof commented Jun 14, 2017

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version all

If you installed assets previously, and then a bundle removed its Resources/public (or you removed the bundle entirely), the corresponding bundle folder in web/bundles is not cleaned when running assets:install again.
Getting a clean web/bundles folder requires deleting the folder and running the install again.

Note that you even end up with broken symlinks in web/bundles in case assets were symlinked rather than copied.

Originally reported as symfony/flex#22 for a case impacting the removal of a bundle.
See symfony/demo#588 for such a case about removing public assets from existing bundles too (we missed at least 2 removals in the history, as the sensiodistribution folder was unused since before the demo switched to symlinks, while framework was after).
@stof stof changed the title [FrameworkBundle] assets:install does not clean unnecessary bundle folders [bug][FrameworkBundle] assets:install does not clean unnecessary bundle folders Jun 14, 2017
@stof stof added the Bug label Jun 14, 2017
@stof stof changed the title [bug][FrameworkBundle] assets:install does not clean unnecessary bundle folders [FrameworkBundle] assets:install does not clean unnecessary bundle folders Jun 14, 2017
@fabpot fabpot added the Good first issue Ideal for your first contribution! (some Symfony experience may be required) label Jun 15, 2017
@GaryPEGEOT
Copy link
Contributor

I take it

@GaryPEGEOT GaryPEGEOT mentioned this issue Jun 15, 2017
Closed
@ghost ghost mentioned this issue Jun 15, 2017
Closed
@ghost
Copy link

ghost commented Jun 15, 2017 •
edited by ghost
Loading

If you installed assets previously, and then a bundle removed its Resources/public (or you removed the bundle entirely), the corresponding bundle folder in web/bundles is not cleaned when running assets:install again.

@GaryPEGEOT I think we need to check for each existing folder If the Bundle still exists

Something like : #23195

This was referenced Jun 15, 2017
Closed
Closed
Closed
fabpot pushed a commit that referenced this issue Jun 16, 2017
@fabpot
[FrameworkBundle] [Command] Clean bundle directory, fixes #23177
180f178
fabpot added a commit that referenced this issue Jun 16, 2017
@fabpot
bug #23195 [FrameworkBundle] [Command] Clean bundle directory, fixes #…
436d5e4 
…23177 (NicolasPion)

This PR was squashed before being merged into the 2.7 branch (closes #23195).

Discussion
----------

[FrameworkBundle] [Command] Clean bundle directory, fixes #23177

| Q             | A
| ------------- | ---
| Branch?       | 2.7 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | no
| Fixed tickets | #23177
| License       | MIT

This PR fix #23177
when running an assets:install, it will remove directorys who do not have anymore a valid Bundle

Commits
-------

180f178 [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
@fabpot fabpot closed this as completed Jun 16, 2017
fabpot added a commit that referenced this issue Jun 20, 2017
@fabpot
Merge branch '2.7' into 2.8
be6af2e 
* 2.7:
  [Routing] Fix XmlFileLoader exception message
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
  Reset redirectCount when throwing exception
  [TwigBundle] Remove template.xml services when templating is disabled
  add content-type header on exception response
  Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
  Fix two edge cases in ResponseCacheStrategy
  [Routing] Expose request in route conditions, if needed and possible
  [Routing] Expose request in route conditions, if needed and possible
  [Translation][FrameworkBundle] Fix resource loading order inconsistency reported in #23034
  [Filesystem] added workaround in Filesystem::rename for PHP bug
  Add tests for ResponseCacheStrategy to document some more edge cases
  [HttpFoundation] added missing docs
  fixes #21606
  [VarDumper] fixes
  [Security] fix switch user _exit without having current token
xabbuh added a commit that referenced this issue Jun 23, 2017
@xabbuh
Merge branch '2.8' into 3.2
80b114e 
* 2.8: (40 commits)
  Show exception is checked twice in ExceptionController of twig
  allow SSI fragments configuration in XML files
  Display a better error message when the toolbar cannot be displayed
  render hidden _method field in form_rest()
  return fallback locales whenever possible
  [Console] Fix catching exception type in QuestionHelper
  [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
  [Routing] Fix XmlFileLoader exception message
  [Translation] Fix FileLoader::loadResource() php doc
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
  Reset redirectCount when throwing exception
  [TwigBundle] Remove template.xml services when templating is disabled
  add content-type header on exception response
  Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
  Fix two edge cases in ResponseCacheStrategy
  [Routing] Expose request in route conditions, if needed and possible
  [Routing] Expose request in route conditions, if needed and possible
  [Translation][FrameworkBundle] Fix resource loading order inconsistency reported in #23034
  [Filesystem] added workaround in Filesystem::rename for PHP bug
  ...
xabbuh added a commit that referenced this issue Jun 24, 2017
@xabbuh
Merge branch '3.2' into 3.3
22723da 
* 3.2: (42 commits)
  Show exception is checked twice in ExceptionController of twig
  allow SSI fragments configuration in XML files
  Display a better error message when the toolbar cannot be displayed
  render hidden _method field in form_rest()
  Add Doctrine Cache to dev dependencies to fix failing unit tests.
  return fallback locales whenever possible
  [Console] Fix catching exception type in QuestionHelper
  [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
  [Routing] Fix XmlFileLoader exception message
  [Translation] Fix FileLoader::loadResource() php doc
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
  Reset redirectCount when throwing exception
  [TwigBundle] Remove template.xml services when templating is disabled
  add content-type header on exception response
  Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
  fixed bad merge
  Fix two edge cases in ResponseCacheStrategy
  [Routing] Expose request in route conditions, if needed and possible
  [Routing] Expose request in route conditions, if needed and possible
  ...
xabbuh added a commit that referenced this issue Jun 24, 2017
@xabbuh
Merge branch '3.3' into 3.4
411d9fa 
* 3.3: (64 commits)
  Show exception is checked twice in ExceptionController of twig
  allow SSI fragments configuration in XML files
  Display a better error message when the toolbar cannot be displayed
  render hidden _method field in form_rest()
  Add Doctrine Cache to dev dependencies to fix failing unit tests.
  return fallback locales whenever possible
  Fix Predis client cluster with pipeline
  [Dotenv] Test load() with multiple paths
  [Console] Fix catching exception type in QuestionHelper
  Improved the exception page when there is no message
  [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
  [Validator] replace hardcoded service id
  [Routing] Fix XmlFileLoader exception message
  [DI] Dedup tags when using instanceof/autoconfigure
  [Translation] Fix FileLoader::loadResource() php doc
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
  fixed CS
  [WebProfilerBundle] Fix the icon for the Cache panel
  [WebServerBundle] Fix router script path and check existence
  ...
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
@nicolas-grekas nicolas-grekas mentioned this issue Sep 16, 2017
Merged
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@xabbuh
Merge branch '2.8' into 3.2
84adcf2 
* 2.8: (40 commits)
  Show exception is checked twice in ExceptionController of twig
  allow SSI fragments configuration in XML files
  Display a better error message when the toolbar cannot be displayed
  render hidden _method field in form_rest()
  return fallback locales whenever possible
  [Console] Fix catching exception type in QuestionHelper
  [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
  [Routing] Fix XmlFileLoader exception message
  [Translation] Fix FileLoader::loadResource() php doc
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes symfony#23177
  Reset redirectCount when throwing exception
  [TwigBundle] Remove template.xml services when templating is disabled
  add content-type header on exception response
  Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
  Fix two edge cases in ResponseCacheStrategy
  [Routing] Expose request in route conditions, if needed and possible
  [Routing] Expose request in route conditions, if needed and possible
  [Translation][FrameworkBundle] Fix resource loading order inconsistency reported in symfony#23034
  [Filesystem] added workaround in Filesystem::rename for PHP bug
  ...
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@xabbuh
Merge branch '3.2' into 3.3
8e4e35c 
* 3.2: (42 commits)
  Show exception is checked twice in ExceptionController of twig
  allow SSI fragments configuration in XML files
  Display a better error message when the toolbar cannot be displayed
  render hidden _method field in form_rest()
  Add Doctrine Cache to dev dependencies to fix failing unit tests.
  return fallback locales whenever possible
  [Console] Fix catching exception type in QuestionHelper
  [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
  [Routing] Fix XmlFileLoader exception message
  [Translation] Fix FileLoader::loadResource() php doc
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes symfony#23177
  Reset redirectCount when throwing exception
  [TwigBundle] Remove template.xml services when templating is disabled
  add content-type header on exception response
  Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
  fixed bad merge
  Fix two edge cases in ResponseCacheStrategy
  [Routing] Expose request in route conditions, if needed and possible
  [Routing] Expose request in route conditions, if needed and possible
  ...
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@xabbuh
Merge branch '3.3' into 3.4
c8a8903 
* 3.3: (64 commits)
  Show exception is checked twice in ExceptionController of twig
  allow SSI fragments configuration in XML files
  Display a better error message when the toolbar cannot be displayed
  render hidden _method field in form_rest()
  Add Doctrine Cache to dev dependencies to fix failing unit tests.
  return fallback locales whenever possible
  Fix Predis client cluster with pipeline
  [Dotenv] Test load() with multiple paths
  [Console] Fix catching exception type in QuestionHelper
  Improved the exception page when there is no message
  [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
  [Validator] replace hardcoded service id
  [Routing] Fix XmlFileLoader exception message
  [DI] Dedup tags when using instanceof/autoconfigure
  [Translation] Fix FileLoader::loadResource() php doc
  Sessions: configurable "use_strict_mode" option for NativeSessionStorage
  [FrameworkBundle] [Command] Clean bundle directory, fixes symfony#23177
  fixed CS
  [WebProfilerBundle] Fix the icon for the Cache panel
  [WebServerBundle] Fix router script path and check existence
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Good first issue Ideal for your first contribution! (some Symfony experience may be required) Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @stof @GaryPEGEOT @carsonbot