Skip to content

Make tests pass on PHP 7.2 #23671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Jul 26, 2017 · 2 comments
Closed

Make tests pass on PHP 7.2 #23671

nicolas-grekas opened this issue Jul 26, 2017 · 2 comments

Comments

@nicolas-grekas
Copy link
Member

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 2.7 & up

We have a policy of not adding anything to allowed failures, because that consumes a Travis job, and nobody cares checking what's there. In the past, I usually opened a PR adding that kind of line and fixing the code to make it green, and maintained that PR until it was ready for merge as a non-allowed-failure line.

If someone would like to help us doing that, that'd be awesome.
@nicolas-grekas nicolas-grekas changed the title Make test pass on PHP 7.2 Make tests pass on PHP 7.2 Jul 26, 2017
@Simperfit
Copy link
Contributor

I could be helping on this, did you already opened a PR about that @nicolas-grekas ?

@nicolas-grekas
Copy link
Member Author

please do!

@Simperfit Simperfit mentioned this issue Jul 29, 2017
Merged
@Simperfit Simperfit mentioned this issue Aug 24, 2017
Merged
fabpot added a commit that referenced this issue Oct 10, 2017
@fabpot
bug #23711 Fix support for PHP 7.2 (Simperfit, nicolas-grekas)
5fd0fe6 
This PR was merged into the 2.7 branch.

Discussion
----------

Fix support for PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       |  2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #23671
| License       | MIT
| Doc PR        | -

There are still the deprecation problem with phpunit since it use `each()`.

There are 3 tests linked to session that I don't know how to fix / what to do, do you have any idea @nicolas-grekas ?

Commits
-------

fdf285b Fix 7.2 compat layer
e229dd0 Fix PHP 7.2 support
@fabpot fabpot closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @nicolas-grekas @Simperfit