Skip to content

Lost commits during merge? #24487

Closed
Closed
@webmake

Description

@webmake
Q A
Bug report? yes
Symfony version 3.2.8-3.3.0

I've just updated symfony/http-foundation dependency from 3.2.8 to 3.3.10, and tests at random place just broke, previously was working with expectation of 'http://localhost/test', now it became 'http://localhosttest'. I'm using getUri method.

I made some research, so I updated to 3.2.13 (seems working version). then I updated to 3.3.0 version (broke), and tried to find in history who deleted '/', but nothing interested found, just addition, but not removal, at commit symfony/http-foundation@9077baf#diff-7edb274bc39ed8c493badba7dd278826

+        if ($requestUri !== '' && $requestUri[0] !== '/') {
+            $requestUri = '/'.$requestUri;
+        }

I'm using getUri method, which uses that discussed preparePathInfo method. More over I found another missing slashes commits:
symfony/http-foundation@9077baf#diff-7edb274bc39ed8c493badba7dd278826
symfony/http-foundation@4665cb9#diff-7edb274bc39ed8c493badba7dd278826
symfony/http-foundation@742db41#diff-7edb274bc39ed8c493badba7dd278826L1849

Please clearify is it missing or deleted for real but no reference to it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions