Skip to content

[Validator] [Twig] added magic method __isset to File Constraint class #24512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
loru88 opened this issue Oct 10, 2017 · 2 comments
Closed

[Validator] [Twig] added magic method __isset to File Constraint class #24512

loru88 opened this issue Oct 10, 2017 · 2 comments
Labels
Feature Validator

Comments

@loru88
Copy link
Contributor

loru88 commented Oct 10, 2017 •
edited
Loading

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes
Symfony version all

In my project I get assert constraints from one of my entity and I use this value in my front end via Twig.
I faced a problem with the property $maxSize of the File Constraint.

As this property is protected I cannot access it via Twig because the magic method __isset is missing, as I read in twig documentation.

so I propose to add this piece of code to be able to get this value accessible in Twig:

    public function __isset($option)
    {
        if ('maxSize' === $option) {
            return true;
        }

        return parent::__isset($option);
    }

this solution work for sure as I tested it, but my question is why this is not a simple public property as the rest of the File Constraint class properties?
@loru88 loru88 mentioned this issue Oct 11, 2017
Closed
@loru88
Copy link
Contributor Author

loru88 commented Oct 11, 2017

I did a pull request for this: #24519

@loru88 loru88 changed the title [Validator] added magic method __isset to File Constraint class [Validator] [Twig] added magic method __isset to File Constraint class Oct 11, 2017
fabpot added a commit that referenced this issue Oct 12, 2017
@fabpot
bug #24519 [Validator] [Twig] added magic method __isset() to File Co…
2059609 
…nstraint class (loru88)

This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #24519).

Discussion
----------

[Validator] [Twig] added magic method __isset()  to File Constraint class

| Q             | A
| ------------- | ---
| Branch?       | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #24512  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

In my project I get assert constraints from one of my entity and I use this value in my front end via Twig.
I faced a problem with the property $maxSize of the File Constraint.

As this property is protected I cannot access it via Twig because the magic method __isset is missing, as I read in twig documentation.
<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the 3.4,
  legacy code removals go to the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

9efb765 [Validator] added magic method __isset()  to File Constraint class
@javiereguiluz
Copy link
Member

Fixed by #24519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javiereguiluz @loru88