Skip to content

Catching deprecations in isolated tests always adds to the Legacy group #24567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexpott opened this issue Oct 15, 2017 · 0 comments
Closed

Catching deprecations in isolated tests always adds to the Legacy group #24567

alexpott opened this issue Oct 15, 2017 · 0 comments

Comments

@alexpott
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.3.x

Recently support for catching deprecations in tests run in isolation was added. At present when any silent deprecations are re-triggered by \Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerTrait::endTest() they are always added to Legacy group. This because trace handling in \Symfony\Bridge\PhpUnit\DeprecationErrorHandler() doesn't find the correct class because the test is run in isolation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolas-grekas @alexpott