Skip to content

[DI] Kernel::getContainerBaseClass() broken #24948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kbond opened this issue Nov 13, 2017 · 0 comments
Closed

[DI] Kernel::getContainerBaseClass() broken #24948

kbond opened this issue Nov 13, 2017 · 0 comments
Labels
Bug DependencyInjection HttpKernel Status: Needs Review
Milestone
3.4

Comments

@kbond
Copy link
Member

kbond commented Nov 13, 2017

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.4.0-BETA4

Looks like using a custom container class was broken between 3.4-BETA3 and 3.4-BETA4. I think #24922 is the culprit.

Because there is now a namespace in the generated container file, the custom container class can't be found.
@xabbuh xabbuh added this to the 3.4 milestone Nov 13, 2017
@nicolas-grekas nicolas-grekas mentioned this issue Nov 13, 2017
Merged
nicolas-grekas added a commit that referenced this issue Nov 13, 2017
@nicolas-grekas
bug #24954 [DI] Fix dumping with custom base class (nicolas-grekas)
772f29f 
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Fix dumping with custom base class

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24948
| License       | MIT
| Doc PR        | -

ping @kbond please confirm it's OK for you

Commits
-------

2dd74ab [DI] Fix dumping with custom base class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection HttpKernel Status: Needs Review
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
5 participants
@kbond @nicolas-grekas @xabbuh @chalasr @carsonbot